feat: Cache toObject(...) using jsi::WeakObject and correctly set externalExternalMemoryPressure
#13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR now improves performance of passing HybridObjects to JS.
jsi::Object
instances of a givenHybridObject
are now cached usingWeakObject
, and can be re-used in subsequent calls.Subsequent calls use the cached object and return it to JS, which avoids going the long prototype assignment route.
setExternalMemoryPressure
can now finally be used properly, since we know that we only have onejsi::Object
instance of the sameHybridObject
in memory, so it will no longer track memory for the same object twice/thrice/...! 🥳obj.foo == obj.foo
now works, since we actually return the samejsi::Object
! It's cached in a weakref, so that finally works. cc @wcandillon