feat: Inform JS GC about memory pressure if it is a HybridObject

mrousavy · Jul 22, 2024 · 2e503ab · 2e503ab
1 parent 47800ec
commit 2e503ab
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/nitro-codegen/src/syntax/swift/SwiftHybridObjectBridge.ts b/packages/nitro-codegen/src/syntax/swift/SwiftHybridObjectBridge.ts
@@ -201,7 +201,7 @@ public:
 
 public:
   // Get memory pressure
-  constexpr virtual size_t getMemorySize() noexcept override {
+  virtual size_t getMemorySize() noexcept override {
     return sizeof(${name.HybridTSwift}) + _swiftPart.getMemorySize();
   }
 

diff --git a/packages/react-native-nitro-modules/cpp/jsi/JSIConverter.hpp b/packages/react-native-nitro-modules/cpp/jsi/JSIConverter.hpp
@@ -348,7 +348,13 @@ template <typename T> struct JSIConverter<T, std::enable_if_t<is_shared_ptr_to_h
       throw jsi::JSError(runtime, "Cannot convert nullptr to HostObject<" + typeName + ">!");
     }
 #endif
-    return jsi::Object::createFromHostObject(runtime, arg);
+    jsi::Object object = jsi::Object::createFromHostObject(runtime, arg);
+    if constexpr (std::is_base_of_v<HybridObject, TPointee>) {
+      // HybridObjects expose their memory size (+ heap allocations), so inform JS GC about it!
+      size_t memorySize = arg->getMemorySize();
+      object.setExternalMemoryPressure(runtime, memorySize);
+    }
+    return object;
   }
 };