fix: Make ThreadPool only two Threads big

mrousavy · Aug 5, 2024 · ee1e7c9 · ee1e7c9
1 parent 950ff03
commit ee1e7c9
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/react-native-nitro-modules/cpp/threading/ThreadPool.cpp b/packages/react-native-nitro-modules/cpp/threading/ThreadPool.cpp
@@ -12,10 +12,10 @@
 namespace margelo::nitro {
 
 ThreadPool::ThreadPool(const char* name, size_t numThreads) : _isAlive(true), _name(name) {
-  Logger::log(TAG, "Creating ThreadPool \"%s\" with %ul threads...", name, numThreads);
+  Logger::log(TAG, "Creating ThreadPool \"%s\" with %i threads...", name, numThreads);
 
   for (size_t i = 0; i < numThreads; ++i) {
-    std::string threadName = std::string(name) + "-" + std::to_string(i);
+    std::string threadName = std::string(name) + "-" + std::to_string(i + 1);
     _workers.emplace_back([this, threadName] {
       // Set the Thread's name
       ThreadUtils::setThreadName(threadName);
@@ -74,7 +74,8 @@ ThreadPool::~ThreadPool() {
 std::shared_ptr<ThreadPool> ThreadPool::getSharedPool() {
   static std::shared_ptr<ThreadPool> shared;
   if (shared == nullptr) {
-    auto numThreads = std::thread::hardware_concurrency();
+    int availableThreads = std::thread::hardware_concurrency();
+    auto numThreads = std::min(availableThreads, 3);
     shared = std::make_shared<ThreadPool>("nitro-thread", numThreads);
   }
   return shared;