Port to JavaScript (ES6) #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jayjun this is fantastic! Getting rid of CoffeeScript is definitely wanted. I'll start using your branch right away so I can use/test it for a couple of days and then I'll merge it. Thanks for your contribution! |
|
@msaraiva Cool, my fork was deleted. Anyway, it’s all back up on GitHub. Let me know if you need a new pull request. |
|
If you merge this I'd love to help out, but I'm just dreadful at CoffeeScript! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be an unofficial move to JavaScript, especially for new development. I think it’s a good move, for aspiring contributors and future-proofing.
In this pull request, I refactored (by hand) all CoffeeScript to JavaScript, and CSON to JSON.
Since the tests were not working to begin with, I can’t say for certain that nothing broke. However, I have used it in my daily work and it’s been 100% the same.
Personally, I never want to learn CoffeeScript well. So, this is really my first step to future contributions!