Fix linking asmdef.exe on DOS with newer gcc #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `-fgnu89-inline` to Make target for `asmdef.exe`. GCC versions 5+ default to a new C standard, which have different handling for `inline` function definitions. The previous fix in line 189 corrects building for cross-compiling; however, those platforms use the `asmdef.sh` script to generate `asmdef.inc`. MS-DOS hosts instead build a helper tool called `asmdef.exe`, and without this new parameter, the build process will fail with "Undefined reference to..." errors on GCC >= version 5. Adding `-fgnu89-inline` fixes the linker errors and allows building with modern GCC versions.
|
Thanks, and sorry for taking so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-fgnu89-inlineto Make target forasmdef.exe.GCC versions 5+ default to a new C standard, which have different handling for
inlinefunction definitions. The previous fix in line 189 corrects building for cross-compiling; however, those platforms use theasmdef.shscript to generateasmdef.inc. MS-DOS hosts instead build a helper tool calledasmdef.exe, and without this new parameter, the build process will fail with "Undefined reference to..." errors on GCC >= version 5.Adding
-fgnu89-inlinefixes the linker errors and allows building with modern GCC versions.