Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline statuses dependency during the build #1458

Merged
merged 2 commits into from
Nov 15, 2022
Merged

fix: inline statuses dependency during the build #1458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c638b67
fix: inline tsup as devDep
mattcosta7 Nov 13, 2022
d5dffb8
Merge branch 'main' into mattcosta7/statuses-dev-dependency
kettanaito Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
"node-fetch": "^2.6.7",
"outvariant": "^1.3.0",
"path-to-regexp": "^6.2.0",
"statuses": "^2.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing it from dependencies

it's already in devDependencies, and if it's not in dependencies then tsup will inline it at build-time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that's funny how it was in both deps and dev deps. A good find.

"strict-event-emitter": "^0.2.6",
"type-fest": "^2.19.0",
"yargs": "^17.3.1"
Expand Down