-
Notifications
You must be signed in to change notification settings - Fork 491
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
libfido2: fix openssh 5.9 winhello support
- Loading branch information
Showing
3 changed files
with
67 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
From 1259e7e047d5556f5552d4cf0d07c86165629be1 Mon Sep 17 00:00:00 2001 | ||
From: Corinna Vinschen <vinschen@redhat.com> | ||
Date: Mon, 14 Feb 2022 21:34:46 +0100 | ||
Subject: [PATCH 1/2] Advertise "uv" capability, not "clientPin". | ||
|
||
Per the CTAP protocol the "uv" capability indicates that the device is | ||
capable of verifying the user within itself, while "clientPin" indicates | ||
that the device is capable of accepting a PIN from the client. WinHello | ||
only supports "uv", but not "clientPin", but current libfido2 advertises | ||
"clientPin", not "uv". Change this in fido_winhello_get_cbor_info. | ||
|
||
Signed-off-by: Corinna Vinschen <vinschen@redhat.com> | ||
--- | ||
src/winhello.c | 2 +- | ||
1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
||
diff --git a/src/winhello.c b/src/winhello.c | ||
index 9de6c6c..2fc6a2a 100644 | ||
--- a/src/winhello.c | ||
+++ b/src/winhello.c | ||
@@ -883,7 +883,7 @@ fido_winhello_get_cbor_info(fido_dev_t *dev, fido_cbor_info_t *ci) | ||
const char *v[3] = { "U2F_V2", "FIDO_2_0", "FIDO_2_1_PRE" }; | ||
const char *e[2] = { "credProtect", "hmac-secret" }; | ||
const char *t[2] = { "nfc", "usb" }; | ||
- const char *o[4] = { "rk", "up", "plat", "clientPin" }; | ||
+ const char *o[4] = { "rk", "up", "plat", "uv" }; | ||
|
||
(void)dev; | ||
|
||
-- | ||
2.35.1.windows.2 | ||
|
26 changes: 26 additions & 0 deletions
26
libfido2/0002-winhello-sort-according-to-CTAP2-canonical-CBOR-enco.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
From 0dde44f5f1a398bab333f66d000f5a67e20c6bb5 Mon Sep 17 00:00:00 2001 | ||
From: pedro martelletto <pedro@yubico.com> | ||
Date: Tue, 15 Feb 2022 10:25:37 +0100 | ||
Subject: [PATCH 2/2] winhello: sort according to CTAP2 canonical CBOR encoding | ||
form | ||
|
||
--- | ||
src/winhello.c | 2 +- | ||
1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
||
diff --git a/src/winhello.c b/src/winhello.c | ||
index 2fc6a2a..63dd82c 100644 | ||
--- a/src/winhello.c | ||
+++ b/src/winhello.c | ||
@@ -883,7 +883,7 @@ fido_winhello_get_cbor_info(fido_dev_t *dev, fido_cbor_info_t *ci) | ||
const char *v[3] = { "U2F_V2", "FIDO_2_0", "FIDO_2_1_PRE" }; | ||
const char *e[2] = { "credProtect", "hmac-secret" }; | ||
const char *t[2] = { "nfc", "usb" }; | ||
- const char *o[4] = { "rk", "up", "plat", "uv" }; | ||
+ const char *o[4] = { "rk", "up", "uv", "plat" }; | ||
|
||
(void)dev; | ||
|
||
-- | ||
2.35.1.windows.2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters