fix: support ethermint's EIP712 implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
force-pushed
the
allows_cosmos_for_verifyingContract
branch
from
e760486
to
b7e1f17
Compare
mtsitrin
force-pushed
the
allows_cosmos_for_verifyingContract
branch
from
b7e1f17
to
7d7cbc2
Compare
jpuri
reviewed
Sep 10, 2024
| @@ -500,7 +500,7 @@ WalletMiddlewareOptions): JsonRpcMiddleware<any, Block> { | |||
| */ | |||
| function validateVerifyingContract(data: string) { | |||
| const { domain: { verifyingContract } = {} } = parseTypedMessage(data); | |||
| if (verifyingContract && !isValidHexAddress(verifyingContract)) { | |||
| if (verifyingContract && !(isValidHexAddress(verifyingContract) || verifyingContract == 'cosmos')) { | |||
There was a problem hiding this comment.
I think it will be better to support any bech32 format for cosmos chain.
I addition can you also plz add comment detailing why we have done this change.
There was a problem hiding this comment.
thx.
currently we want to solve the hard coded "cosmos" issue, no need for generic bech32 support.
fixed and opened PR to the origin
MetaMask#333
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MM is broken since v12.1.1 for cosmos chains that use
https://github.com/evmos/ethermintas EVM adapter.Ethermintuses hard coded"cosmos"string as theVerifyingContractfield, which is broken sincevalidateVerifyingContractintroduced in MM.This PR adds support to allow "cosmos" as the
VerifyingContractvalue.