좋아요 스킴 초안. Ref #1 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr-lgl
reviewed
Jan 12, 2021
|
|
||
| @Repository | ||
| public interface LikeRepository extends CrudRepository<Like, String> { | ||
| public default Like findByTrackId(String trackId) { |
There was a problem hiding this comment.
별도로 얘기했으나, 남기는 게 좋을 거 같아 코멘트 남겨둡니다.
현재 trackId가 현재 엔티티 컬럼에 존재하지 않고, 보통 인터페이스에서 컬럼명으로 whereColumn으로 메서드를 정의하면 컴파일 시점에 알아서 관련 코드를 만들어 줍니다.
public Like findByTrackId(String trackId);그리고, 보통 단일 객체를 찾을 땐 JPA 인터페이스에서 기본적으로 Optional<Entity>를 리턴하는데 이렇게 추가되는 메서드에도 옵셔널을 쓰는 게 좋을 거 같은데 어떨까요?
There was a problem hiding this comment.
코멘트 남겨주셨던 부분은 우선, 삭제했습니다 !
JeongmyeongzZ
commented
Jan 22, 2021
src/main/java/io/mtudy/soundcloud/like/domain/entities/AlbumLike.java
Outdated
Show resolved
Hide resolved
src/main/java/io/mtudy/soundcloud/like/domain/entities/AlbumLike.java
Outdated
Show resolved
Hide resolved
src/main/java/io/mtudy/soundcloud/like/domain/entities/Like.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Repository | ||
| public interface LikeRepository extends CrudRepository<Like, String> { | ||
| public default Like findByTrackId(String trackId) { |
There was a problem hiding this comment.
코멘트 남겨주셨던 부분은 우선, 삭제했습니다 !
src/main/resources/schema.graphqls
Outdated
| type Mutation { | ||
| createTrack(input: CreateTrackInput!): Track | ||
| likePlaylist(input: likePlaylistInput!): Like |
There was a problem hiding this comment.
이부분은 지금 용어가 혼용 돼 있는데 정리가 필요합니당
플레이리스트를 좋아요 누른다 => like playlist로 접근했ㄴ었는데, like 라는 자원을 생성하는 Create playlist like 뭐 이런식으로 섞여있는데 용어를 어떤식으로 정리하면 좋을까요 ?
There was a problem hiding this comment.
음 이건 저도 잘 몰라서 레퍼런스를 좀 찾아봤습니다.
- https://www.moesif.com/blog/api-guide/graphql-best-practices-resources-and-design-patterns/
- https://www.apollographql.com/blog/designing-graphql-mutations-e09de826ed97/
해당 질문에 대해선 두 번째 글이 알찬데, 동사를 먼저 쓰라고 하네요.
지금 케이스에선 likePlaylist면 괜찮지않나 싶습니다.
|
빌드가.. 깨집니다! |
cr-lgl
reviewed
Jan 22, 2021
src/main/java/io/mtudy/soundcloud/like/domain/entities/AlbumLike.java
Outdated
Show resolved
Hide resolved
cr-lgl
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1