Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InputBase] Declare global mui-auto-fill(-cancel) keyframes #19497

Merged
merged 2 commits into from
Feb 1, 2020
Merged

[InputBase] Declare global mui-auto-fill(-cancel) keyframes #19497

merged 2 commits into from
Feb 1, 2020

Conversation

martinjlowm
Copy link
Contributor

@martinjlowm martinjlowm commented Jan 31, 2020 •
edited
Loading

Browser autofill workaround logic requires static animation name references for
keyframes. Enabling disableGlobal renames such keyframes unless they are marked
as global.

Fixes #19224

This also disables class documentation for @global identifiers (assuming that is okay).

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 31, 2020 •
edited
Loading

Details of bundle changes.

Comparing: ac5c1ae...cf1a64e

bundle Size Change Size Gzip Change Gzip
@material-ui/core ▲ +18 B (0.00% ) 361 kB ▲ +12 B (+0.01% ) 98.7 kB
TablePagination ▲ +18 B (+0.01% ) 143 kB ▲ +11 B (+0.03% ) 41.9 kB
NativeSelect ▲ +18 B (+0.02% ) 77 kB ▲ +8 B (+0.03% ) 24.3 kB
@material-ui/core[umd] ▲ +18 B (+0.01% ) 317 kB ▲ +5 B (+0.01% ) 91.9 kB
FilledInput ▲ +18 B (+0.02% ) 73.7 kB ▲ +5 B (+0.02% ) 22.9 kB
Input ▲ +18 B (+0.02% ) 72.7 kB ▲ +5 B (+0.02% ) 22.7 kB
Select ▲ +18 B (+0.02% ) 117 kB ▲ +5 B (+0.01% ) 34.6 kB
TextField ▲ +18 B (+0.01% ) 125 kB ▲ +5 B (+0.01% ) 36.6 kB
OutlinedInput ▲ +18 B (+0.02% ) 74.7 kB ▲ +3 B (+0.01% ) 23.3 kB
InputBase ▲ +18 B (+0.03% ) 70.8 kB ▼ -1 B (-0.00% ) 22.2 kB
@material-ui/lab -- 185 kB -- 55.2 kB
@material-ui/styles -- 51.4 kB -- 15.4 kB
@material-ui/system -- 14.8 kB -- 4.07 kB
Alert -- 84 kB -- 26.3 kB
AlertTitle -- 64.3 kB -- 20.3 kB
AppBar -- 64.1 kB -- 20.1 kB
Autocomplete -- 132 kB -- 41.3 kB
Avatar -- 65.4 kB -- 20.7 kB
AvatarGroup -- 62.4 kB -- 19.6 kB
Backdrop -- 68 kB -- 21 kB
Badge -- 65.5 kB -- 20.4 kB
BottomNavigation -- 62.6 kB -- 19.6 kB
BottomNavigationAction -- 75.7 kB -- 23.9 kB
Box -- 71 kB -- 21.7 kB
Breadcrumbs -- 67.9 kB -- 21.3 kB
Button -- 79.9 kB -- 24.5 kB
ButtonBase -- 74.2 kB -- 23.3 kB
ButtonGroup -- 83.4 kB -- 25.5 kB
Card -- 63 kB -- 19.7 kB
CardActionArea -- 75.3 kB -- 23.7 kB
CardActions -- 62.2 kB -- 19.5 kB
CardContent -- 62.1 kB -- 19.5 kB
CardHeader -- 65.2 kB -- 20.5 kB
CardMedia -- 62.5 kB -- 19.7 kB
Checkbox -- 83.2 kB -- 26.3 kB
Chip -- 82.8 kB -- 25.4 kB
CircularProgress -- 64.3 kB -- 20.3 kB
ClickAwayListener -- 3.91 kB -- 1.55 kB
Collapse -- 68.2 kB -- 21.1 kB
colorManipulator -- 3.88 kB -- 1.52 kB
Container -- 63.4 kB -- 19.8 kB
CssBaseline -- 57.7 kB -- 18.1 kB
Dialog -- 83.2 kB -- 25.9 kB
DialogActions -- 62.2 kB -- 19.5 kB
DialogContent -- 62.4 kB -- 19.6 kB
DialogContentText -- 64.2 kB -- 20.2 kB
DialogTitle -- 64.4 kB -- 20.2 kB
Divider -- 62.7 kB -- 19.7 kB
docs.landing -- 50.5 kB -- 13.2 kB
docs.main -- 596 kB -- 194 kB
Drawer -- 85 kB -- 25.8 kB
ExpansionPanel -- 72.5 kB -- 22.7 kB
ExpansionPanelActions -- 62.2 kB -- 19.5 kB
ExpansionPanelDetails -- 62.1 kB -- 19.5 kB
ExpansionPanelSummary -- 78.3 kB -- 24.7 kB
Fab -- 77 kB -- 24 kB
Fade -- 23.4 kB -- 7.98 kB
FormControl -- 64.6 kB -- 20.2 kB
FormControlLabel -- 65.7 kB -- 20.7 kB
FormGroup -- 62.2 kB -- 19.5 kB
FormHelperText -- 63.5 kB -- 20 kB
FormLabel -- 63.6 kB -- 19.8 kB
Grid -- 65.3 kB -- 20.5 kB
GridList -- 62.6 kB -- 19.7 kB
GridListTile -- 63.9 kB -- 20 kB
GridListTileBar -- 63.4 kB -- 19.9 kB
Grow -- 24 kB -- 8.19 kB
Hidden -- 66.1 kB -- 20.8 kB
Icon -- 62.9 kB -- 19.8 kB
IconButton -- 76.3 kB -- 23.8 kB
InputAdornment -- 65.3 kB -- 20.5 kB
InputLabel -- 65.5 kB -- 20.2 kB
LinearProgress -- 65.5 kB -- 20.5 kB
Link -- 66.8 kB -- 21.1 kB
List -- 62.5 kB -- 19.5 kB
ListItem -- 77.3 kB -- 24.2 kB
ListItemAvatar -- 62.3 kB -- 19.5 kB
ListItemIcon -- 62.3 kB -- 19.5 kB
ListItemSecondaryAction -- 62.2 kB -- 19.5 kB
ListItemText -- 65.1 kB -- 20.5 kB
ListSubheader -- 62.9 kB -- 19.8 kB
Menu -- 89 kB -- 27.4 kB
MenuItem -- 78.4 kB -- 24.5 kB
MenuList -- 66.2 kB -- 20.7 kB
MobileStepper -- 68 kB -- 21.4 kB
Modal -- 14.5 kB -- 5.05 kB
NoSsr -- 2.19 kB -- 1.04 kB
Paper -- 62.5 kB -- 19.5 kB
Popover -- 83.3 kB -- 25.8 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.92 kB -- 1.3 kB
Radio -- 84.2 kB -- 26.5 kB
RadioGroup -- 64.6 kB -- 20.1 kB
Rating -- 70.7 kB -- 22.7 kB
RootRef -- 4.24 kB -- 1.64 kB
Skeleton -- 63.1 kB -- 20 kB
Slide -- 25.5 kB -- 8.71 kB
Slider -- 76.8 kB -- 24.3 kB
Snackbar -- 75.6 kB -- 23.7 kB
SnackbarContent -- 63.7 kB -- 20.1 kB
SpeedDial -- 86.4 kB -- 27.2 kB
SpeedDialAction -- 119 kB -- 37.5 kB
SpeedDialIcon -- 64.7 kB -- 20.3 kB
Step -- 62.8 kB -- 19.7 kB
StepButton -- 82.5 kB -- 26.1 kB
StepConnector -- 62.9 kB -- 19.8 kB
StepContent -- 69.3 kB -- 21.7 kB
StepIcon -- 64.8 kB -- 20.2 kB
StepLabel -- 68.8 kB -- 21.7 kB
Stepper -- 65 kB -- 20.5 kB
styles/createMuiTheme -- 16.5 kB -- 5.81 kB
SvgIcon -- 63.2 kB -- 19.8 kB
SwipeableDrawer -- 92.4 kB -- 28.9 kB
Switch -- 82.3 kB -- 26 kB
Tab -- 76.5 kB -- 24.2 kB
Table -- 62.7 kB -- 19.7 kB
TableBody -- 62.3 kB -- 19.5 kB
TableCell -- 64.2 kB -- 20.2 kB
TableContainer -- 62.1 kB -- 19.5 kB
TableFooter -- 62.3 kB -- 19.5 kB
TableHead -- 62.3 kB -- 19.5 kB
TableRow -- 62.6 kB -- 19.7 kB
TableSortLabel -- 77.6 kB -- 24.4 kB
Tabs -- 85.8 kB -- 27.2 kB
TextareaAutosize -- 5.12 kB -- 2.14 kB
ToggleButton -- 76.3 kB -- 24.2 kB
ToggleButtonGroup -- 63.4 kB -- 20 kB
Toolbar -- 62.5 kB -- 19.6 kB
Tooltip -- 102 kB -- 32.4 kB
TreeItem -- 74.2 kB -- 23.5 kB
TreeView -- 66.8 kB -- 21.1 kB
Typography -- 63.8 kB -- 20 kB
useAutocomplete -- 14.6 kB -- 5.29 kB
useMediaQuery -- 2.58 kB -- 1.07 kB
Zoom -- 23.5 kB -- 8.1 kB

Generated by 🚫 dangerJS against cf1a64e

@martinjlowm martinjlowm force-pushed the fix-input-base-with-disable-global branch from 4459b2f to 1fdaa03 Compare January 31, 2020 13:45
@martinjlowm
Copy link
Contributor Author

martinjlowm commented Jan 31, 2020 •
edited
Loading

Prettier fails currently - I cannot replicate it with yarn prettier locally. @oliviertassinari Never mind - had to run prettier:all to fix things.

[InputBase] Declare global mui-auto-fill(-cancel) keyframes
332b6c8 
Browser autofill workaround logic requires static animation name references for
keyframes. Enabling disableGlobal renames such keyframes unless they are marked
as global.
@martinjlowm martinjlowm force-pushed the fix-input-base-with-disable-global branch from daedb3b to 0387d86 Compare January 31, 2020 15:40
@martinjlowm martinjlowm force-pushed the fix-input-base-with-disable-global branch from 0387d86 to cf1a64e Compare January 31, 2020 16:33
@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! PR: ready to ship bug 🐛 Something doesn't work labels Jan 31, 2020
@oliviertassinari oliviertassinari merged commit 845a4d1 into mui:master Feb 1, 2020
@oliviertassinari
Copy link
Member

@martinjlowm It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Feb 13, 2020
@martinjlowm @EsoterikStare
[InputBase] Declare global mui-auto-fill(-cancel) keyframes (mui#19497)
f2a36f7
This was referenced Feb 25, 2020
Closed
Merged
Merged
This was referenced Mar 10, 2020
Merged
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Open
This was referenced Apr 16, 2020
Merged
Closed
This was referenced Aug 30, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TextField] Label shrink issue with disableGlobal: true
3 participants
@martinjlowm @mui-pr-bot @oliviertassinari