Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .markdownlint-cli2.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ export default {
config: {
...baseline.config,
MD038: false, // false positives in MDX
MD041: false, // false positives in MDX
},
};
19 changes: 19 additions & 0 deletions babel.config.mjs
Original file line number Diff line number Diff line change
@@ -1,10 +1,29 @@
import getBaseConfig from '@mui/internal-code-infra/babel-config';
import * as path from 'node:path';
import { fileURLToPath } from 'node:url';

const dirname = path.dirname(fileURLToPath(import.meta.url));

const errorCodesPath = path.join(dirname, 'docs/src/error-codes.json');

export default function getBabelConfig(api) {
const baseConfig = getBaseConfig(api);

const plugins = [
[
'@mui/internal-babel-plugin-minify-errors',
{
missingError: 'annotate',
runtimeModule: '#formatErrorMessage',
detection: 'opt-out',
errorCodesPath,
},
],
];

return {
...baseConfig,
plugins: [...baseConfig.plugins, ...plugins],
overrides: [
{
exclude: /\.test\.(js|ts|tsx)$/,
Expand Down
17 changes: 17 additions & 0 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,20 @@ Package managers other than pnpm (like npm or Yarn) are not supported and will n

[You can follow this guide](https://github.com/mui/base-ui/blob/HEAD/CONTRIBUTING.md)
on how to get started contributing to Base UI.

## Error code extraction

Errors in production are minified. They are extracted out of the source code by running the command

```bash
pnpm extract-error-codes
```

This updates the `./src/error-codes.json` file with the newly extracted errors.

Important: If you just altered the text of an error, you are allowed to update the existing error code with the new text in `./src/error-codes.json`, but only under the following conditions:

1. There hasn't been an update to the semantic meaning of the error message. Error codes need to outlive Base UI versions, so the same code must mean the same thing across versions.
2. There hasn't been a change in parameters, no added and no removed.
Comment on lines +32 to +33
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this be "hardish" to maintain without automation as time goes by? 🤔


In both of those cases, always create a new error code lline in `./src/error-codes.json`.
1 change: 0 additions & 1 deletion docs/public/static/error-codes.json

This file was deleted.

3 changes: 2 additions & 1 deletion docs/scripts/reportBrokenLinks.mts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-console */
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { fileURLToPath, pathToFileURL } from 'node:url';
import { readFile, writeFile } from 'node:fs/promises';
import { globby } from 'globby';
import * as jsxRuntime from 'react/jsx-runtime';
Expand Down Expand Up @@ -108,6 +108,7 @@ async function getLinksAndAnchors(

const { tableOfContents } = await evaluate(mdxSource, {
...jsxRuntime,
baseUrl: pathToFileURL(filePath),
remarkPlugins: [remarkGfm],
rehypePlugins: [
rehypeReference,
Expand Down
23 changes: 23 additions & 0 deletions docs/src/app/(public)/(content)/production-error/ErrorCode.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
'use client';
import * as React from 'react';
import { useSearchParams } from 'next/navigation';

export interface ErrorDisplayProps {
msg: string;
}

function ErrorCodeContent() {
return useSearchParams().get('code') ?? '';
}

/**
* Client component that interpolates arguments in an error message. Must be
* a client component because it reads the search params.
*/
export default function ErrorCode() {
return (
<React.Suspense fallback="…">
<ErrorCodeContent />
</React.Suspense>
);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
'use client';
import * as React from 'react';
import { useSearchParams } from 'next/navigation';
import codes from 'docs/src/error-codes.json';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have basic inline markdown formatting rendering in a followup.


function ErrorMessageWithArgs() {
const searchParams = useSearchParams();

return React.useMemo(() => {
const code = searchParams.get('code');
const msg =
(code ? (codes as Partial<Record<string, string>>)[code ?? ''] : null) ??
`Unknown error code: ${code}`;
const args = searchParams.getAll('args[]');
let index = 0;
return msg.replace(/%s/g, () => {
const replacement = args[index];
index += 1;
return replacement === undefined ? '[missing argument]' : replacement;
});
}, [searchParams]);
}

/**
* Client component that interpolates arguments in an error message. Must be
* a client component because it reads the search params.
*/
export default function ErrorDisplay() {
return (
<code>
<React.Suspense fallback="…">
<ErrorMessageWithArgs />
</React.Suspense>
</code>
);
}
16 changes: 16 additions & 0 deletions docs/src/app/(public)/(content)/production-error/page.mdx
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import ErrorCode from './ErrorCode';
import ErrorDisplay from './ErrorDisplay';

# Production error #<ErrorCode />

<Subtitle>Explanation for minified production error message.</Subtitle>
<Meta
name="description"
content="In the production build, error messages are minified to keep your application lightweight."
/>

A minified Base UI error occurred in the production build of React.

The full error message:

<ErrorDisplay />
78 changes: 78 additions & 0 deletions docs/src/error-codes.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
{
"1": "Unsupported number of selectors",
"2": "Unsupported number of arguments",
"3": "Base UI: CheckboxGroupContext is missing. CheckboxGroup parts must be placed within <CheckboxGroup>.",
"4": "Base UI: DirectionContext is missing.",
"5": "Base UI: MenubarContext is missing. Menubar parts must be placed within <Menubar>.",
"6": "Base UI: useToast must be used within <Toast.Provider>.",
"7": "Base UI: ToggleGroupContext is missing. ToggleGroup parts must be placed within <ToggleGroup>.",
"8": "Base UI: Render element or function are not defined.",
"9": "Base UI: AccordionItemContext is missing. Accordion parts must be placed within <Accordion.Item>.",
"10": "Base UI: AccordionRootContext is missing. Accordion parts must be placed within <Accordion.Root>.",
"11": "Base UI: <AlertDialog.Portal> is missing.",
"12": "Base UI: AlertDialogRootContext is missing. AlertDialog parts must be placed within <AlertDialog.Root>.",
"13": "Base UI: AvatarRootContext is missing. Avatar parts must be placed within <Avatar.Root>.",
"14": "Base UI: CheckboxRootContext is missing. Checkbox parts must be placed within <Checkbox.Root>.",
"15": "Base UI: CollapsibleRootContext is missing. Collapsible parts must be placed within <Collapsible.Root>.",
"16": "Base UI: CompositeRootContext is missing. Composite parts must be placed within <Composite.Root>.",
"17": "useComboboxChipContext must be used within a ComboboxChip",
"18": "Base UI: ComboboxGroupContext is missing. ComboboxGroup parts must be placed within <Combobox.Group>.",
"19": "Base UI: ComboboxItemContext is missing. ComboboxItem parts must be placed within <Combobox.Item>.",
"20": "Base UI: <Combobox.Portal> is missing.",
"21": "Base UI: <Combobox.Popup> and <Combobox.Arrow> must be used within the <Combobox.Positioner> component",
"22": "Base UI: ComboboxRootContext is missing. Combobox parts must be placed within <Combobox.Root>.",
"23": "Base UI: ComboboxFloatingContext is missing. Combobox parts must be placed within <Combobox.Root>.",
"24": "Base UI: ComboboxItemsContext is missing. Combobox parts must be placed within <Combobox.Root>.",
"25": "Base UI: ContextMenuRootContext is missing. ContextMenu parts must be placed within <ContextMenu.Root>.",
"26": "Base UI: <Dialog.Portal> is missing.",
"27": "Base UI: DialogRootContext is missing. Dialog parts must be placed within <Dialog.Root>.",
"28": "Base UI: FieldRootContext is missing. Field parts must be placed within <Field.Root>.",
"29": "[Floating UI]: Invalid grid - item width at index %s is greater than grid columns",
"30": "Base UI: MenuCheckboxItemContext is missing. MenuCheckboxItem parts must be placed within <Menu.CheckboxItem>.",
"31": "Base UI: MenuGroupRootContext is missing. Menu group parts must be used within <Menu.Group>.",
"32": "Base UI: <Menu.Portal> is missing.",
"33": "Base UI: MenuPositionerContext is missing. MenuPositioner parts must be placed within <Menu.Positioner>.",
"34": "Base UI: MenuRadioGroupContext is missing. MenuRadioGroup parts must be placed within <Menu.RadioGroup>.",
"35": "Base UI: MenuRadioItemContext is missing. MenuRadioItem parts must be placed within <Menu.RadioItem>.",
"36": "Base UI: MenuRootContext is missing. Menu parts must be placed within <Menu.Root>.",
"37": "Base UI: <Menu.SubmenuTrigger> must be placed in <Menu.SubmenuRoot>.",
"38": "Base UI: MeterRootContext is missing. Meter parts must be placed within <Meter.Root>.",
"39": "Base UI: NavigationMenuItem parts must be used within a <NavigationMenu.Item>.",
"40": "Base UI: <NavigationMenu.Portal> is missing.",
"41": "Base UI: NavigationMenuRootContext is missing. Navigation Menu parts must be placed within <NavigationMenu.Root>.",
"42": "Base UI: NavigationMenuPositionerContext is missing. NavigationMenuPositioner parts must be placed within <NavigationMenu.Positioner>.",
"43": "Base UI: NumberFieldRootContext is missing. NumberField parts must be placed within <NumberField.Root>.",
"44": "Base UI: NumberFieldScrubAreaContext is missing. NumberFieldScrubArea parts must be placed within <NumberField.ScrubArea>.",
"45": "Base UI: <Popover.Portal> is missing.",
"46": "Base UI: PopoverPositionerContext is missing. PopoverPositioner parts must be placed within <Popover.Positioner>.",
"47": "Base UI: PopoverRootContext is missing. Popover parts must be placed within <Popover.Root>.",
"48": "Base UI: <PreviewCard.Portal> is missing.",
"49": "Base UI: <PreviewCard.Popup> and <PreviewCard.Arrow> must be used within the <PreviewCard.Positioner> component",
"50": "Base UI: PreviewCardRootContext is missing. PreviewCard parts must be placed within <PreviewCard.Root>.",
"51": "Base UI: ProgressRootContext is missing. Progress parts must be placed within <Progress.Root>.",
"52": "Base UI: RadioRootContext is missing. Radio parts must be placed within <Radio.Root>.",
"53": "Base UI: ScrollAreaRootContext is missing. ScrollArea parts must be placed within <ScrollArea.Root>.",
"54": "Base UI: ScrollAreaScrollbarContext is missing. ScrollAreaScrollbar parts must be placed within <ScrollArea.Scrollbar>.",
"55": "Base UI: ScrollAreaViewportContext missing. ScrollAreaViewport parts must be placed within <ScrollArea.Viewport>.",
"56": "Base UI: SelectGroupContext is missing. SelectGroup parts must be placed within <Select.Group>.",
"57": "Base UI: SelectItemContext is missing. SelectItem parts must be placed within <Select.Item>.",
"58": "Base UI: <Select.Portal> is missing.",
"59": "Base UI: SelectPositionerContext is missing. SelectPositioner parts must be placed within <Select.Positioner>.",
"60": "Base UI: SelectRootContext is missing. Select parts must be placed within <Select.Root>.",
"61": "Base UI: SelectFloatingContext is missing. Select parts must be placed within <Select.Root>.",
"62": "Base UI: SliderRootContext is missing. Slider parts must be placed within <Slider.Root>.",
"63": "Base UI: SwitchRootContext is missing. Switch parts must be placed within <Switch.Root>.",
"64": "Base UI: TabsRootContext is missing. Tabs parts must be placed within <Tabs.Root>.",
"65": "Base UI: TabsListContext is missing. TabsList parts must be placed within <Tabs.List>.",
"66": "Base UI: ToastRootContext is missing. Toast parts must be used within <Toast.Root>.",
"67": "Base UI: ToastViewportContext is missing. Toast parts must be placed within <Toast.Viewport>.",
"68": "Base UI: ToolbarGroupContext is missing. ToolbarGroup parts must be placed within <Toolbar.Group>.",
"69": "Base UI: ToolbarRootContext is missing. Toolbar parts must be placed within <Toolbar.Root>.",
"70": "Base UI: <Tooltip.Portal> is missing.",
"71": "Base UI: TooltipPositionerContext is missing. TooltipPositioner parts must be placed within <Tooltip.Positioner>.",
"72": "Base UI: TooltipRootContext is missing. Tooltip parts must be placed within <Tooltip.Root>.",
"73": "Base UI: useToastManager must be used within <Toast.Provider>.",
"74": "Base UI: PopoverTrigger must be either used within a PopoverRoot component or have the `handle` prop set.",
"75": "Base UI: PopoverTrigger must have an `id` prop specified.",
"76": "Base UI: selectors are required to call useState."
}
5 changes: 5 additions & 0 deletions docs/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@

declare module 'gtag.js';
declare module '@mui/monorepo/docs/nextConfigDocsInfra.js';

declare module '*.mdx' {
const MDXComponent: (props) => JSX.Element;
export default MDXComponent;
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"docs:start": "pnpm --filter docs serve",
"docs:link-check": "pnpm --filter docs link-check",
"docs:generate-llms": "pnpm --filter docs run generate-llms",
"extract-error-codes": "cross-env MUI_EXTRACT_ERROR_CODES=true lerna run --concurrency 1 build:stable",
"extract-error-codes": "code-infra extract-error-codes --errorCodesPath docs/src/error-codes.json --detection opt-out",
"eslint": "eslint . --cache --report-unused-disable-directives --ext .js,.ts,.tsx,.mts --max-warnings 0 && pnpm -r lint",
"eslint:ci": "eslint . --report-unused-disable-directives --ext .js,.ts,.tsx,.mts --max-warnings 0 && pnpm -r lint",
"stylelint": "stylelint --reportInvalidScopeDisables --reportNeedlessDisables \"docs/**/*.{js,ts,tsx}\" \"**/*.css\" --ignore-path .lintignore",
Expand Down
3 changes: 2 additions & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@
"./use-render": "./src/use-render/index.ts"
},
"imports": {
"#test-utils": "./test/index.ts"
"#test-utils": "./test/index.ts",
"#formatErrorMessage": "@base-ui-components/utils/formatErrorMessage"
},
"type": "commonjs",
"scripts": {
Expand Down
3 changes: 3 additions & 0 deletions packages/utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
"./store": "./src/store/index.ts",
"./*": "./src/*.ts"
},
"imports": {
"#formatErrorMessage": "./src/formatErrorMessage.ts"
},
"type": "commonjs",
"scripts": {
"prebuild": "rimraf --glob build build-tests \"*.tsbuildinfo\"",
Expand Down
14 changes: 14 additions & 0 deletions packages/utils/src/formatErrorMessage.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
/**
* WARNING: Don't import this directly. It's imported by the code generated by
* `@mui/interal-babel-plugin-minify-errors`. Make sure to always use string literals in `Error`
* constructors to ensure the plugin works as expected. Supported patterns include:
* throw new Error('My message');
* throw new Error(`My message: ${foo}`);
* throw new Error(`My message: ${foo}` + 'another string');
* ...
*/
export default function formatErrorMessage(code: number, ...args: string[]): string {
const url = new URL(`https://base-ui.com/production-error/${code}`);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented here #1463

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be this or https://base-ui.com/production-error?code=${code}

args.forEach((arg) => url.searchParams.append('args[]', arg));
return `Base UI error #${code}; visit ${url} for the full message.`;
}
4 changes: 2 additions & 2 deletions packages/utils/src/store/createSelector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export const createSelector = ((
} else if (a) {
selector = a;
} else {
throw new Error('Missing arguments');
throw /* minify-error-disabled */ new Error('Missing arguments');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't really save that much.

}

return selector;
Expand Down Expand Up @@ -206,7 +206,7 @@ export const createSelectorMemoized: CreateSelectorFunction = (...selectors: any
case 2: return fn(state, a1, a2);
case 3: return fn(state, a1, a2, a3);
default:
throw new Error('unreachable');
throw /* minify-error-disabled */ new Error('unreachable');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

}
};

Expand Down
4 changes: 3 additions & 1 deletion packages/utils/src/useEventCallback.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ function createStableCallback() {

function assertNotCalled() {
if (process.env.NODE_ENV !== 'production') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 That's a case we may be able to detect in the babel plugin

throw new Error('Base UI: Cannot call an event handler while rendering.');
throw /* minify-error-disabled */ new Error(
'Base UI: Cannot call an event handler while rendering.',
);
}
}
Loading