Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Explicitly define exported subpaths #870

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,8 @@ jobs:
name: Build packages
command: pnpm release:build
- run:
name: Are the types wrong?
command: pnpm -r test:package-types
name: Verify built packages
command: pnpm -r test:package

workflows:
version: 2
Expand Down
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
.nyc_output
/coverage
/docs/.next
/docs/data/**/*.js
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to lint autogenerated files

/docs/export
/docs/src/app/playground/
/packages/react/**/*.min.*
Expand Down
5 changes: 2 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const baseline = require('@mui/monorepo/.eslintrc');
const path = require('path');

const OneLevelImportMessage = [
'Prefer one level nested imports to avoid bundling everything in dev mode or breaking CJS/ESM split.',
Expand All @@ -17,8 +16,8 @@ module.exports = {
...baseline,
settings: {
'import/resolver': {
webpack: {
config: path.join(__dirname, './webpackBaseConfig.js'),
typescript: {
project: ['docs/tsconfig.json', 'packages/*/tsconfig.test.json'],
},
},
},
Expand Down
1 change: 0 additions & 1 deletion babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ module.exports = function getBabelConfig(api) {
const useESModules = !api.env(['node']);

const defaultAlias = {
'@base-ui-components/react': resolveAliasPath('./packages/react/src'),
docs: resolveAliasPath('./docs'),
test: resolveAliasPath('./test'),
'@mui-internal/api-docs-builder': resolveAliasPath(
Expand Down
4 changes: 2 additions & 2 deletions docs/data/api/no-ssr.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"fallback": { "type": { "name": "node" }, "default": "null" }
},
"name": "NoSsr",
"imports": ["import { NoSsr } from '@base-ui-components/react/no-ssr';"],
"imports": ["import { NoSsr } from '@base-ui-components/react/unstable-no-ssr';"],
"classes": [],
"spread": false,
"themeDefaultProps": null,
"muiName": "NoSsr",
"filename": "/packages/react/src/no-ssr/NoSsr.tsx",
"filename": "/packages/react/src/unstable-no-ssr/NoSsr.tsx",
"inheritance": null,
"demos": "<ul><li><a href=\"/components/react-no-ssr/\">No SSR</a></li></ul>",
"cssComponent": false
Expand Down
2 changes: 1 addition & 1 deletion docs/data/components/no-ssr/FrameDeferring.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client';
import * as React from 'react';
import { NoSsr } from '@base-ui-components/react/no-ssr';
import { NoSsr } from '@base-ui-components/react/unstable-no-ssr';
import { Box } from '@mui/system';

function LargeTree() {
Expand Down
2 changes: 1 addition & 1 deletion docs/data/components/no-ssr/FrameDeferring.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client';
import * as React from 'react';
import { NoSsr } from '@base-ui-components/react/no-ssr';
import { NoSsr } from '@base-ui-components/react/unstable-no-ssr';
import { Box } from '@mui/system';

function LargeTree(): any {
Expand Down
2 changes: 1 addition & 1 deletion docs/data/components/no-ssr/SimpleNoSsr.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client';
import * as React from 'react';
import { NoSsr } from '@base-ui-components/react/no-ssr';
import { NoSsr } from '@base-ui-components/react/unstable-no-ssr';
import { Box } from '@mui/system';

export default function SimpleNoSsr() {
Expand Down
2 changes: 1 addition & 1 deletion docs/data/components/no-ssr/SimpleNoSsr.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client';
import * as React from 'react';
import { NoSsr } from '@base-ui-components/react/no-ssr';
import { NoSsr } from '@base-ui-components/react/unstable-no-ssr';
import { Box } from '@mui/system';

export default function SimpleNoSsr() {
Expand Down
263 changes: 0 additions & 263 deletions docs/src/app/experiments/slider-marks.tsx

This file was deleted.

Loading