[TextField] fix typescript complications when 'component' prop is pas…

…sed to FormHelpterTextProps
mui · Apr 13, 2020 · a150ab9 · a150ab9
1 parent 8e2f0cc
commit a150ab9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/packages/material-ui/src/TextField/TextField.d.ts b/packages/material-ui/src/TextField/TextField.d.ts
@@ -48,7 +48,10 @@ export interface BaseTextFieldProps
  /**
  * Props applied to the [`FormHelperText`](/api/form-helper-text/) element.
  */
- FormHelperTextProps?: Partial<FormHelperTextProps>;
+ FormHelperTextProps?: FormHelperTextProps<
+ React.ElementType,
+ { component: React.ElementType | JSX.Element }
+ >;
  /**
  * If `true`, the input will take up the full width of its container.
  */

diff --git a/packages/material-ui/src/TextField/TextField.spec.tsx b/packages/material-ui/src/TextField/TextField.spec.tsx
@@ -1,5 +1,5 @@
 import * as React from 'react';
-import TextField from '@material-ui/core/TextField';
+import TextField, { TextFieldProps } from '@material-ui/core/TextField';
 
 {
  // https://github.com/mui-org/material-ui/issues/12999
@@ -67,3 +67,19 @@ function FocusHandlerTest() {
 
  return null;
 }
+
+function createElementTextFieldTest() {
+ // $ExpectError
+ React.createElement<TextFieldProps>(TextField, {
+ FormHelperTextProps: {
+ component: 'some-wrong-element',
+ },
+ });
+
+ // $ExpectError
+ React.createElement<TextFieldProps>(TextField, {
+ FormHelperTextProps: {
+ component: 1234,
+ },
+ });
+}