Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stepper] Mobile version #7033

Closed
alexhayes opened this issue Jun 2, 2017 · 6 comments · Fixed by #7043
Closed

[Stepper] Mobile version #7033

alexhayes opened this issue Jun 2, 2017 · 6 comments · Fixed by #7043
Labels
component: stepper This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@alexhayes
Copy link
Contributor

alexhayes commented Jun 2, 2017 •
edited
Loading

As far as I can tell a Mobile Stepper has not been implemented as outlined in https://material.io/guidelines/components/steppers.html#steppers-types-of-steps and I need one for a few projects I'm working on.

I'm wondering if something like this is currently in progress and if not would it be something that would like be welcomed as a PR?

Text Dots Progress
@oliviertassinari oliviertassinari added the new feature New feature or request label Jun 2, 2017
@oliviertassinari
Copy link
Member

That's definitely something we haven't implemented so far. Yes, we need to port the Stepper component to the next branch #4799. We would love to see a PR for such feature on the next branch 👍 .

@oliviertassinari oliviertassinari changed the title Mobile Stepper [Stepper] Mobile version Jun 2, 2017
@alexhayes
Copy link
Contributor Author

@oliviertassinari would the preference be to create a separate MobileStepper component or combine it with the current Stepper component?

@oliviertassinari
Copy link
Member

I think that we will need different components to implement that feature, at least at the low level. Maybe we could find a higher-level API to mutualize the desktop and mobile version, but that's challenging, I wouldn't start by that.

@oliviertassinari oliviertassinari added the component: stepper This is the name of the generic UI component, not the React module! label Jun 2, 2017
@alexhayes
Copy link
Contributor Author

Cool, agreed, separate components makes sense to begin with.

alexhayes added a commit to alexhayes/material-ui that referenced this issue Jun 2, 2017
@alexhayes
Refs mui#7033 - Mobile Stepper with dots.
c63c2e2
@alexhayes
Copy link
Contributor Author

alexhayes commented Jun 2, 2017 •
edited
Loading

Initial dots implementation done.

image

I need to do;

@oliviertassinari
Copy link
Member

Fix this

You need to add DotsMobileStepper in the MUI_SHEET_ORDER object.

alexhayes added a commit to alexhayes/material-ui that referenced this issue Jun 2, 2017
@alexhayes
Refs mui#7033 - Remove ugly hack to get the dots stepper to position …
92db44b 
…correctly in the demo.
alexhayes added a commit to alexhayes/material-ui that referenced this issue Jun 2, 2017
@alexhayes
Refs mui#7033 - Mobile Stepper text implementation
b1a0ef5
alexhayes added a commit to alexhayes/material-ui that referenced this issue Jun 2, 2017
@alexhayes
Refs mui#7033 - Removed elevation from Mobile Stepper Paper.
858bc57
alexhayes added a commit to alexhayes/material-ui that referenced this issue Jun 2, 2017
@alexhayes
Refs mui#7033 - Mobile Stepper text implementation
39c66d9
alexhayes added a commit to alexhayes/material-ui that referenced this issue Jun 2, 2017
@alexhayes
Refs mui#7033 - Mobile stepper progress implementation
eb028c0
alexhayes added a commit to alexhayes/material-ui that referenced this issue Jun 2, 2017
@alexhayes
Refs mui#7033 - Fixed propType progressClassName and added API docs.
d3367f0
alexhayes added a commit to alexhayes/material-ui that referenced this issue Jun 3, 2017
@alexhayes
Fixes mui#7033 - [Stepper] Mobile version
f7e1917
alexhayes added a commit to alexhayes/material-ui that referenced this issue Jun 3, 2017
@alexhayes
[Stepper] Mobile version - fixes mui#7033
d5e4b19
@alexhayes alexhayes mentioned this issue Jun 3, 2017
Merged
3 tasks
oliviertassinari pushed a commit that referenced this issue Jun 5, 2017
@alexhayes @oliviertassinari
[Stepper] Mobile version (#7043)
de4c31b 
* [Stepper] Mobile version - fixes #7033

* Change classes.mobileStepper for classes.root

* Use theme.spacing.unit rather than hard coded padding and dot width/height

* Optimise use of classNames for dotClassName

* Fixed classes.root tests

* Added props backButtonText and nextButtonText

* Added position prop making MobileStepper not fixed by default.

* Fixed linting issues

* [MobileStepper] Second iteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: stepper This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Stepper] Mobile version alexhayes/material-ui
2 participants
@alexhayes @oliviertassinari