[core] Remove usage of theme.spacing.unit #12022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change comes from an internal discussion with @mbrookes. The usage of
theme.spacing.unit
was only here to illustrate the link with the 8dp spacing unit. In practice, we do not expect people to change the value. By doing this change, we make the style generation lighter (-0.3 Kb gzipped).P.S. I have only changed the source code, not the demos.
P.S. I wish we had a performance benchmark to see the implications of such change.