From d388cb322e49a36117cadb1400253c7321a0c825 Mon Sep 17 00:00:00 2001 From: sai6855 Date: Sun, 24 Dec 2023 21:21:04 +0530 Subject: [PATCH 1/6] trigger From 21f6a1c4ef241ab1adb5efa15fbbf95f57b71433 Mon Sep 17 00:00:00 2001 From: sai6855 Date: Thu, 4 Jan 2024 12:43:53 +0530 Subject: [PATCH 2/6] remove inputId prop in NumberInputOwnProps --- .../mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx | 5 +++++ .../mui-base/src/Unstable_NumberInput/NumberInput.types.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx diff --git a/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx b/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx new file mode 100644 index 00000000000000..22bba14cfd1815 --- /dev/null +++ b/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx @@ -0,0 +1,5 @@ +import * as React from 'react'; +import { NumberInput } from './NumberInput'; + +/* @ts-expect-error */ +; diff --git a/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts b/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts index 198356e8da45c4..cc49fe7e830cbc 100644 --- a/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts +++ b/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts @@ -12,7 +12,7 @@ export interface NumberInputRootSlotPropsOverrides {} export interface NumberInputInputSlotPropsOverrides {} export interface NumberInputStepperButtonSlotPropsOverrides {} -export type NumberInputOwnProps = Omit & { +export type NumberInputOwnProps = Omit & { /** * Trailing adornment for this input. */ From bdd60377604db29f4d8eb99dbdda11e257d991bb Mon Sep 17 00:00:00 2001 From: sai6855 Date: Thu, 4 Jan 2024 13:02:08 +0530 Subject: [PATCH 3/6] Fix formatting in NumberInputOwnProps type definition --- packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts b/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts index cc49fe7e830cbc..630c9127c85d18 100644 --- a/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts +++ b/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts @@ -12,7 +12,7 @@ export interface NumberInputRootSlotPropsOverrides {} export interface NumberInputInputSlotPropsOverrides {} export interface NumberInputStepperButtonSlotPropsOverrides {} -export type NumberInputOwnProps = Omit & { +export type NumberInputOwnProps = Omit & { /** * Trailing adornment for this input. */ From 2182f3b12e3978a7e33e6ffbb8a0d9f9bcfab678 Mon Sep 17 00:00:00 2001 From: sai6855 Date: Thu, 4 Jan 2024 13:23:25 +0530 Subject: [PATCH 4/6] trigger From 1fa90cdf8f108bd0fab2ac02e7812415109f53e8 Mon Sep 17 00:00:00 2001 From: sai6855 Date: Wed, 10 Jan 2024 12:34:54 +0530 Subject: [PATCH 5/6] apply changes from code review --- .../mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx b/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx index 22bba14cfd1815..14bfc8aa615431 100644 --- a/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx +++ b/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx @@ -1,5 +1,5 @@ import * as React from 'react'; -import { NumberInput } from './NumberInput'; +import { Unstable_NumberInput as NumberInput } from '@mui/base/Unstable_NumberInput'; -/* @ts-expect-error */ +/* @ts-expect-error - inputId shouldn't be available on NumberInput */ ; From 8ea34d25ee7954b17b3c1adea9763144d826e583 Mon Sep 17 00:00:00 2001 From: sai6855 Date: Wed, 10 Jan 2024 14:11:35 +0530 Subject: [PATCH 6/6] Remove inputRef from type --- .../mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx | 3 +++ .../mui-base/src/Unstable_NumberInput/NumberInput.types.ts | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx b/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx index 14bfc8aa615431..4e2388c2e3b441 100644 --- a/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx +++ b/packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx @@ -3,3 +3,6 @@ import { Unstable_NumberInput as NumberInput } from '@mui/base/Unstable_NumberIn /* @ts-expect-error - inputId shouldn't be available on NumberInput */ ; + +/* @ts-expect-error - inputRef shouldn't be available on NumberInput */ +; diff --git a/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts b/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts index 630c9127c85d18..9775c60eb31e51 100644 --- a/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts +++ b/packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts @@ -12,7 +12,10 @@ export interface NumberInputRootSlotPropsOverrides {} export interface NumberInputInputSlotPropsOverrides {} export interface NumberInputStepperButtonSlotPropsOverrides {} -export type NumberInputOwnProps = Omit & { +export type NumberInputOwnProps = Omit< + UseNumberInputParameters, + 'error' | 'inputId' | 'inputRef' +> & { /** * Trailing adornment for this input. */