[examples] Freeze examples dependency range #43435
Conversation
|
To addon this, I think the README of the examples should be updated to point to diff --git a/examples/material-ui-cra-ts/README.md b/examples/material-ui-cra-ts/README.md
index dfd9da114d..dbb9c7cdbb 100644
--- a/examples/material-ui-cra-ts/README.md
+++ b/examples/material-ui-cra-ts/README.md
@@ -7,7 +7,7 @@ Download the example [or clone the repo](https://github.com/mui/material-ui):
<!-- #default-branch-switch -->
## The idea behind the example
This example demonstrates how you can use Material UI with [Create React App](https://github.com/facebookincubator/create-react-app) in [TypeScript](https://github.com/Microsoft/TypeScript).
It includes `@mui/material` and its peer dependencies, including [Emotion](https://emotion.sh/docs/introduction), the default style engine in Material UI v6.
-If you prefer, you can [use styled-components instead](https://mui.com/material-ui/integrations/interoperability/#styled-components).
+If you prefer, you can [use styled-components instead](https://v5.mui.com/material-ui/integrations/interoperability/#styled-components).
## What's next?
<!-- #default-branch-switch -->
You now have a working example project.
-You can head back to the documentation and continue by browsing the [templates](https://mui.com/material-ui/getting-started/templates/) section.
+You can head back to the documentation and continue by browsing the [templates](https://v5.mui.com/material-ui/getting-started/templates/) section.
|
| "react": "^18.0.0", | ||
| "react-dom": "^18.0.0", | ||
| "react-scripts": "^5.0.0" |
There was a problem hiding this comment.
I think we can use latest here, as we plan to bring the React 19 support to v5 too. @DiegoAndai what are your thoughts?
There was a problem hiding this comment.
Ah yeah, I didn't realize we were planning on bringing React 19 support to v5 when I created this PR. I assumed that because we released v6 before React 19 is stable, we wouldn't need to spend time on this. At least, I believe we fulfilled all the conditions to have React 19 only in v6 #42381 (comment).
Now, no real preferences on my end. I think https://tools-public.mui.com/prod/pages/npmVersion?package=@mui/material could tell us what's the best move. React 19 could help us consolidate the community on a single major.
There was a problem hiding this comment.
I'm reverting the "react" changes for now, it's fewer changes, it's never bad to scope down PRs 😄. It gives us more time to figure out the best move with React v19 on Material UI v5.
oliviertassinari
force-pushed
the
prepare-v6-stable-release
branch
from
e03e7a0
to
a58f16b
Compare
Fix more instances of #43435
A continuation of #43435.
Make sure we can continue to easily run the examples on v5 once we release v6 as stable. This can help spot regressions. This is something that we used to care about, e.g. #28358.
Edit: oh annoying, the CI fails on the v5.x branch too, it's not specific to this PR. Fixing that in #43564