Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v7.3.2 #12971
v7.3.2 #12971
Changes from 1 commit
05dd991
e82afa2
3cc7066
bc3ae7a
a27ac58
178e2be
e3cafa7
038683e
e548850
3d1def8
fce659c
8381cd3
054d023
6fd4939
302726d
950ff4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we bump when there are no changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lately we've been releasing whatever lerna detects, that sometimes means that packages, which only received dependency bumps would also be picked up.
This decision has not been finalized yet, but we did release such packages with the last few releases.
Personally, I lean more towards not releasing what has not changed, but that's just my opinion with "hyper-optimisation" in mind. 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it for now as @michelengelen suggested. I don't have any preference, but would like to add our decision to the readme file so it is documented for the next new joiner 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with it.
Totally agree that it should be documented once we land on a decision. 👌