From 9d8d3595f7cbf9e7247e238c3d54536b37d5e27c Mon Sep 17 00:00:00 2001 From: Lukas Date: Tue, 11 Jun 2024 17:38:09 +0300 Subject: [PATCH 1/3] Use specific (same as in package.json) pnpm version --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 6f545dc011d12..2f56f832119c6 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -66,7 +66,7 @@ commands: name: Install pnpm package manager command: | corepack enable - corepack prepare pnpm@latest-8 --activate + corepack prepare pnpm@9.2.0 --activate - run: name: Prepare playwright hash command: pnpm list --json --filter playwright > /tmp/playwright_info.json From 127e6daf0db29072ba00e95040b7932819e54b34 Mon Sep 17 00:00:00 2001 From: Lukas Date: Tue, 11 Jun 2024 17:38:45 +0300 Subject: [PATCH 2/3] Simplify danger step setup --- .circleci/config.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 2f56f832119c6..71ec5e12452ef 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -276,15 +276,9 @@ jobs: command: pnpm test:argos run_danger: <<: *default-job - docker: - - image: mcr.microsoft.com/playwright:v1.44.1-focal - environment: - NODE_ENV: development # Needed if playwright is in `devDependencies` steps: - checkout - - install_js: - # TODO remove, no needed - browsers: true + - install_js - run: name: Run danger on PRs command: pnpm danger ci --fail-on-errors From 267791c68ee4ef5ed4636750febe0f42fb23b909 Mon Sep 17 00:00:00 2001 From: Lukas Date: Tue, 11 Jun 2024 23:14:08 +0300 Subject: [PATCH 3/3] Update .circleci/config.yml Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Lukas --- .circleci/config.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 71ec5e12452ef..adb1bf6c916be 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -66,7 +66,6 @@ commands: name: Install pnpm package manager command: | corepack enable - corepack prepare pnpm@9.2.0 --activate - run: name: Prepare playwright hash command: pnpm list --json --filter playwright > /tmp/playwright_info.json