[DataGridPro] Fix crash when using pinnedRows + getRowClassName props and rows=[]
#5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
bug 🐛
|
These are the results for the performance tests:
|
cherniavskii
force-pushed
the
pinnedRows-with-empty-rows
branch
from
eee5c90
to
f5abc74
Compare
m4theushw
approved these changes
Aug 22, 2022
Comment on lines
+776
to
+777
| expect(getRowById(0)!.classList.contains(className)).to.equal(true); | ||
| expect(getRowById(1)!.classList.contains(className)).to.equal(true); |
There was a problem hiding this comment.
Much simpler.
Suggested change
| expect(getRowById(0)!.classList.contains(className)).to.equal(true); | |
| expect(getRowById(1)!.classList.contains(className)).to.equal(true); | |
| expect(getRowById(0)!).to.have.class(className); | |
| expect(getRowById(1)!).to.have.class(className); |
There was a problem hiding this comment.
I did this intentionally to have meaningful error message when test fails.
See #3607 (comment)
There was a problem hiding this comment.
I've commented the related issue in mocha: mochajs/mocha#4910
There was a problem hiding this comment.
Once mocha fixes this issue we can use the other syntax here, keeping the same convention like other tests.
cherniavskii
force-pushed
the
pinnedRows-with-empty-rows
branch
from
cd16a06
to
298be49
Compare
3 tasks
m4theushw
approved these changes
Aug 25, 2022
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
…rops and `rows=[]` (mui#5851)
This was referenced Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5845