-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental support for Windows ARM64 #6315
Conversation
Thank you so much for these changes! We will try to review and test everything soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 17 of 21 files at r1, 1 of 3 files at r2, all commit messages.
Reviewable status: 18 of 21 files reviewed, 1 unresolved discussion (waiting on @dpaoliello)
gui/tasks/distribution.js
line 405 at r2 (raw file):
} // Use host architecture. return 'x64';
Assuming that the host is x64
won't work on arm. This might deserve a comment at the very least.
@dlon this PR is not yet ready for review: first we need the prebuilt |
@dpaoliello The binaries are available on the |
7d80319
to
b7c6982
Compare
@dpaoliello It works great using Wireguard! We can get OpenVPN to work as well by building |
Yep, using x64 The alternative is to get an ARM64 openvpn.exe - it looks like the last successful build of Mullvad's openvpn repo did include ARM64 Windows, but the artifacts are now expired: https://github.com/mullvad/openvpn/actions/runs/7058997763 |
We don't think it makes sense to block this PR on an ARM64 openvpn build. Let's include an x64 build of We currently cross-compile openvpn using mingw on Linux, which can't target arm, and our branch doesn't even compile with MSVC. We'll likely switch soon, though. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 21 files at r1, 8 of 12 files at r4, 4 of 6 files at r5, all commit messages.
Reviewable status: 24 of 26 files reviewed, 1 unresolved discussion (waiting on @dpaoliello)
test/ci-runtests.sh
line 102 at r1 (raw file):
;; windows*) echo "MullvadVPN-${version}_x64.exe"
The _x64
suffix is missing now from the function in test/scripts/test-utils.sh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 24 of 26 files reviewed, 2 unresolved discussions (waiting on @dpaoliello)
ci/buildserver-build.sh
line 228 at r5 (raw file):
pushd "$artifact_dir" for original_file in MullvadVPN-*-dev-*{.deb,.rpm,.exe,.pkg}; do new_file=$(echo "$original_file" | sed -nE "s/^(MullvadVPN-.*-dev-.*)(_amd64\.deb|_x86_64\.rpm|_arm64\.deb|_aarch64\.rpm|\.exe|\.pkg)$/\1$version_suffix\2/p")
I believe $version_suffix
should come before _x64 | _arm64
.
Fixed the issues above and also added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r5, 9 of 9 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 21 files at r1, 2 of 12 files at r4, 1 of 6 files at r5, 5 of 9 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 26 of 27 files reviewed, all discussions resolved (waiting on @dlon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r7.
Reviewable status: complete! all files reviewed, all discussions resolved
Adds experimental support for Windows ARM64:
maybenot
that uses newer version ofring
that supports Windows ARM64.cargo update
.NOTE: WireGuard is working, but OpenVPN is not.
This change is