Add smart routing to daita settings data

[rablador]

---

This change is 

[linear]

IOS-838 Add smart routing to daita settings data

[buggmagnet]

2024-09-30 10:26:45.003185+0200 MullvadVPN[1536:467494] [LoadTunnelConfigurationOperation] Cannot read settings.
Caused by: Key "daitaState" not found at "data.daita". (domain = NSCocoaErrorDomain, code = 4865)

If I upgrade from an existing AppStore Build, I cannot connect anymore.
Please make sure to:

• Test upgrading from a public version
• Add unit tests (ideally automated one but that's up to your discretion) that test this.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[rablador]

Ah, my bad, I forgot about migration!

Reviewable status: complete! all files reviewed, all discussions resolved

[rablador]

Should we either:

1. Keep state (rather than renaming to daitaState) and add smartRouting prop?
2. Deprecate state and introduce daitaStateand smartRoutingState (like current code)?

Reviewable status: complete! all files reviewed, all discussions resolved

[rablador]

Ex of second option:

@available(*, deprecated, renamed: "daitaState")
public let state: DAITAState = .off

[...]

public init(from decoder: any Decoder) throws {
    let container = try decoder.container(keyedBy: CodingKeys.self)

    daitaState = try container.decodeIfPresent(DAITAState.self, forKey: .daitaState)
        ?? container.decodeIfPresent(DAITAState.self, forKey: .state)
        ?? .off

    smartRoutingState = try container.decode(SmartRoutingState.self, forKey: .smartRoutingState)
}

Reviewable status: complete! all files reviewed, all discussions resolved

[buggmagnet]

Option 1 is better IMHO, daitaState is redundant since we're already talking about a DaitaSettings object.

Reviewable status: 12 of 13 files reviewed, all discussions resolved

[rablador]

What would the name of the smart routing state? We could call it simply smartRouting, but then we'd end up with state and smartRouting where both are states.

Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on @buggmagnet)

[buggmagnet]

Ok I see what you mean, then let's go with your original proposition. We rename state to daitaState and introduce the smart routing var as well.

Reviewable status: 12 of 13 files reviewed, all discussions resolved

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.