-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logic for showing DAITA filter pill #6944
Conversation
f87bff4
to
3feb1df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 17 of 26 files at r1.
Reviewable status: 3 of 27 files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/Coordinators/Settings/SettingsCoordinator.swift
line 242 at r1 (raw file):
let controller = SettingsViewController( interactor: interactorFactory.makeSettingsInteractor(), alertPresenter: AlertPresenter(context: self)
AlertPresenter
doesn't hold a weak reference to its context, I wonder if we're not creating a retain cycle here 🤔
It probably should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 27 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/Coordinators/Settings/SettingsCoordinator.swift
line 242 at r1 (raw file):
Previously, buggmagnet wrote…
AlertPresenter
doesn't hold a weak reference to its context, I wonder if we're not creating a retain cycle here 🤔
It probably should
We're doing this a lot. Should we make context weak?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 27 files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/Coordinators/Settings/SettingsCoordinator.swift
line 242 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
We're doing this a lot. Should we make context weak?
I think so yes, out of precaution, it shouldn't have any negative impact
3feb1df
to
ba89bf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 28 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/Coordinators/Settings/SettingsCoordinator.swift
line 242 at r1 (raw file):
Previously, buggmagnet wrote…
I think so yes, out of precaution, it shouldn't have any negative impact
Done.
ba89bf6
to
9c033f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 26 files at r1, 16 of 21 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: 23 of 28 files reviewed, all discussions resolved
9c033f9
to
0aa4f44
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
The filter pill in the filter view should be shown under the following circumstances:
Singlehop:
Multihop:
This change is