-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building for Xcode 15 and 16 #7063
Conversation
f209f12
to
8d3ad1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
Can I have a patch here without the workaround for the optimizer? I'll try it out on Xcode 16.2 beta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pinkisemils All the changes in the PR are to work around the optimiser crashing when we build the MockRelease
scheme
As long as you stick to Debug
the code will build and run normally.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/TunnelManager/UIApplication+Extensions.swift
line 2 at r1 (raw file):
// // UIApplication+Extensions.swift
since the it's not extension anymore, I suppose we have to rename the file name and it's location.
Breaks all the same on the 16.2 beta 😿 Probably works with these changes too. |
8d3ad1b
to
222b371
Compare
222b371
to
dcde0c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 16 of 19 files reviewed, 1 unresolved discussion (waiting on @mojganii and @rablador)
ios/MullvadVPN/TunnelManager/UIApplication+Extensions.swift
line 2 at r1 (raw file):
Previously, mojganii wrote…
since the it's not extension anymore, I suppose we have to rename the file name and it's location.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
dcde0c5
to
993b284
Compare
This PR makes building both with Xcode 15 and Xcode 16 possible.
This change is