Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit_hash to end to end test #7093

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Add commit_hash to end to end test #7093

merged 1 commit into from
Oct 30, 2024

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Oct 29, 2024

This PR enables iOS end-to-end tests to receive a commit_hash as an input, allowing the workflow to check out that specific commit. This input is optional, and if no value is provided, the workflow will use the latest commit from the branch that triggered it. The primary reason for this change is that iOS settings migration tests require an older commit version. By reusing iOS end-to-end tests for these cases and consolidating workflows and jobs in one place, it becomes necessary to fetch the repository at a specific reference.


This change is Reviewable

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @mojganii)


.github/workflows/ios-end-to-end-tests.yml line 18 at r1 (raw file):

        type: string
        required: false
        

Remove extra spaces.


.github/workflows/ios-end-to-end-tests.yml line 85 at r1 (raw file):

        id: set-commit-hash
        run: |
          if [ -z "${{ inputs.commit_hash }}" ]; then

I think it makes more sense to check for the existence of something rather than the opposite. Ie:
if [ -n "${{ inputs.commit_hash }}" ]; then


.github/workflows/ios-end-to-end-tests.yml line 91 at r1 (raw file):

          fi
        shell: bash
        

Remove extra spaces.

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @mojganii)

Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @rablador)


.github/workflows/ios-end-to-end-tests.yml line 18 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Remove extra spaces.

that is intentional


.github/workflows/ios-end-to-end-tests.yml line 85 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

I think it makes more sense to check for the existence of something rather than the opposite. Ie:
if [ -n "${{ inputs.commit_hash }}" ]; then

makes more sense


.github/workflows/ios-end-to-end-tests.yml line 91 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Remove extra spaces.

that is intentional

@mojganii mojganii force-pushed the refactor-ci-script branch 3 times, most recently from f48dd94 to 97ae7fc Compare October 30, 2024 07:30
Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @rablador)


.github/workflows/ios-end-to-end-tests.yml line 18 at r1 (raw file):

Previously, mojganii wrote…

that is intentional

Removed!


.github/workflows/ios-end-to-end-tests.yml line 91 at r1 (raw file):

Previously, mojganii wrote…

that is intentional

Removed!

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @rablador)

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@pinkisemils pinkisemils added the iOS Issues related to iOS label Oct 30, 2024
@buggmagnet buggmagnet dismissed rablador’s stale review October 30, 2024 10:02

Go home github, you're drunk

@buggmagnet buggmagnet merged commit ddfb746 into main Oct 30, 2024
9 checks passed
@buggmagnet buggmagnet deleted the refactor-ci-script branch October 30, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants