-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commit_hash to end to end test #7093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @mojganii)
.github/workflows/ios-end-to-end-tests.yml
line 18 at r1 (raw file):
type: string required: false
Remove extra spaces.
.github/workflows/ios-end-to-end-tests.yml
line 85 at r1 (raw file):
id: set-commit-hash run: | if [ -z "${{ inputs.commit_hash }}" ]; then
I think it makes more sense to check for the existence of something rather than the opposite. Ie:
if [ -n "${{ inputs.commit_hash }}" ]; then
.github/workflows/ios-end-to-end-tests.yml
line 91 at r1 (raw file):
fi shell: bash
Remove extra spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @mojganii)
07f2618
to
f9eca6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @rablador)
.github/workflows/ios-end-to-end-tests.yml
line 18 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Remove extra spaces.
that is intentional
.github/workflows/ios-end-to-end-tests.yml
line 85 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
I think it makes more sense to check for the existence of something rather than the opposite. Ie:
if [ -n "${{ inputs.commit_hash }}" ]; then
makes more sense
.github/workflows/ios-end-to-end-tests.yml
line 91 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Remove extra spaces.
that is intentional
f48dd94
to
97ae7fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @rablador)
.github/workflows/ios-end-to-end-tests.yml
line 18 at r1 (raw file):
Previously, mojganii wrote…
that is intentional
Removed!
.github/workflows/ios-end-to-end-tests.yml
line 91 at r1 (raw file):
Previously, mojganii wrote…
that is intentional
Removed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @rablador)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
97ae7fc
to
47e5349
Compare
This PR enables iOS end-to-end tests to receive a commit_hash as an input, allowing the workflow to check out that specific commit. This input is optional, and if no value is provided, the workflow will use the latest commit from the branch that triggered it. The primary reason for this change is that iOS settings migration tests require an older commit version. By reusing iOS end-to-end tests for these cases and consolidating workflows and jobs in one place, it becomes necessary to fetch the repository at a specific reference.
This change is