feat: optimize decoding #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up decoding by about 20%. Suggested by @jwinkler2083233 in Fixes #14.
Stebalien
force-pushed
the
feat/optimize-decode
branch
from
2281d72
to
6a12e0b
Compare
willscott
approved these changes
Nov 22, 2022
| // "eof" will look like a success. | ||
| // If we've read part of a value, this is not a | ||
| // success. | ||
| err = io.ErrUnexpectedEOF | ||
| } | ||
| return 0, err | ||
| } | ||
| if (i == 8 && b >= 0x80) || i >= MaxLenUvarint63 { | ||
| if (s == 56 && b >= 0x80) || s >= (7*MaxLenUvarint63) { |
There was a problem hiding this comment.
this is the only use of MaxLenUvarint63 - should we have the constant be 63, rather than a 7 here and 9 as the constant?
There was a problem hiding this comment.
It's a public constant and useful for checking buffer sizes.
There was a problem hiding this comment.
(also used by go-msgio, which we really need to kill)
willscott
approved these changes
Nov 23, 2022
|
Thanks for the review! |
Kubuxu
reviewed
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up decoding by about 20%. Suggested by @jwinkler2083233 in
Fixes #14.