chore: Add lint exception to make CI pass again #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umgefahren
force-pushed
the
add-lint-exception
branch
from
d87e8f8
to
c3593fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rust 1.80 cfg checking was introduced in stable. Since we use
cfg(nightly)in one test to check the number of variants, we need to tell the compiler that this is okay.It might seem like a dirty fix, but it's a widely used workaround:
cfg(nightly)exception in Cargo.tomlcfg(nightly)in Rust filesIt's also one of the suggested solutions by rust itself (and it's more efficient then using a build.rs file).
Originally posted by @umgefahren in #110 (comment)