Add engineIsModelValid #4255
Open
Add engineIsModelValid #4255
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about CJ models (do we even need to do a check if Also I'm not that good with C but wouldn't it make more sense to first check if the ID is larger than 20k and then try to get the model info? Anyways I could use this function yes, maybe for a hard clean of all models or something similar. |
FileEX
suggested changes
Jul 20, 2025
| @@ -2593,3 +2594,13 @@ void CLuaEngineDefs::EnginePreloadWorldArea(CVector position, std::optional<Prel | |||
| if (option == PreloadAreaOption::ALL || option == PreloadAreaOption::COLLISIONS) | |||
| g_pGame->GetStreaming()->LoadSceneCollision(&position); | |||
| } | |||
|
|
|||
| bool CLuaEngineDefs::EngineIsModelValid(uint uiModelId) | |||
|
|
||
| bool CLuaEngineDefs::EngineIsModelValid(uint uiModelId) | ||
| { | ||
| CModelInfo* pModelInfo = g_pGame->GetModelInfo(uiModelId); |
There was a problem hiding this comment.
CModelInfo* modelInfo = g_pGame->GetModelInfo(modelId);
Comment on lines
+2602
to
+2605
| if (uiModelId >= 20000 || !pModelInfo) | ||
| return false; | ||
|
|
||
| return true; |
There was a problem hiding this comment.
return (modelId < 20000 && modelInfo);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new utility function engineIsModelValid.
Some scripts may need to check whether a model ID corresponds to a valid and loaded model. This function provides a simple way to verify if a model is within valid bounds and has a valid model info entry.
It checks whether the model ID is above the base DFF limit and ensures that the corresponding model info exists and is valid.