Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove new keyword for query parsers without specific parameter #1373

Conversation

GuticaStefan
Copy link
Collaborator

@GuticaStefan GuticaStefan commented Nov 6, 2024

Reasoning

  • we should use NestJs singleton dependecy injection for query parsers that don't have specific parameters for performance and memory improvements

Proposed Changes

  • remove new keyword for query parsers without specific parameter

How to test

  • it should work the same as before

Copy link

github-actions bot commented Nov 6, 2024

k6 load testing comparison.
Base Commit Hash: 5079d6b
Target Commit Hash: 9121558

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Mex47.74530.2151.6053.6551.38272.3256.2458.00+7.64% 🔴-48.64% ✅+8.99% 🔴+8.10% 🔴
Accounts47.79574.8951.6453.7753.151751.3656.3158.32+11.20% 🔴+204.64% 🔴+9.04% 🔴+8.45% 🔴
Pool47.90720.6651.6553.7251.81618.9056.2758.08+8.16% 🔴-14.12% ✅+8.95% 🔴+8.11% 🔴
Transactions63.933374.1952.5355.9572.184949.1157.1760.20+12.91% 🔴+46.68% 🔴+8.83% 🔴+7.60% 🔴
Tokens48.07815.6251.6053.7651.90684.5856.2558.07+7.96% 🔴-16.07% ✅+9.01% 🔴+8.01% 🔴
Blocks54.521464.1852.4055.1058.941340.3556.6359.28+8.11% 🔴-8.46% ✅+8.08% 🔴+7.60% 🔴
Nodes47.56224.3051.6753.8251.65473.4556.2658.08+8.60% 🔴+111.07% 🔴+8.90% 🔴+7.91% 🔴
Test Run Duration60002.1860008.50

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@GuticaStefan GuticaStefan self-assigned this Nov 6, 2024
bogdan-rosianu
bogdan-rosianu previously approved these changes Nov 6, 2024
cfaur09
cfaur09 previously approved these changes Nov 8, 2024
@GuticaStefan GuticaStefan dismissed stale reviews from cfaur09 and bogdan-rosianu via 9121558 December 12, 2024 07:57
@dragos-rebegea dragos-rebegea merged commit dfc82d6 into development Dec 12, 2024
5 checks passed
@dragos-rebegea dragos-rebegea deleted the API-50-use-singleton-instance-for-each-raw-parameter-parser branch December 12, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants