Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix empty token type from gateway #1398

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

bogdan-rosianu
Copy link
Contributor

Reasoning

  • <api>/accounts/erd1.../tokens would have returned empty type because an empty type field can come from gateway

Proposed Changes

  • if empty type comes from gateway, then use the type fetched from indexer

How to test

  • <api>/accounts/erd1tgqkv2yqdq2eytqhsut3rkcdyvmt7ngt4lq5pvhass3u79dl98tsc07cjq/tokens?size=400&includeMetaESDT=true should have the type field for MetaESDT as well

@bogdan-rosianu bogdan-rosianu self-assigned this Nov 27, 2024
Copy link

k6 load testing comparison.
Base Commit Hash: 5cf7be0
Target Commit Hash: 429c410

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Mex46.46630.2050.2751.6950.43392.6554.9856.75+8.54% 🔴-37.69% ✅+9.37% 🔴+9.79% 🔴
Pool46.35498.7850.2751.6850.40406.9555.0256.83+8.74% 🔴-18.41% ✅+9.44% 🔴+9.96% 🔴
Tokens46.37606.5850.2551.7050.65518.9055.0256.83+9.23% 🔴-14.45% ✅+9.50% 🔴+9.92% 🔴
Nodes46.98913.8250.5051.9450.56579.6755.0356.80+7.62% 🔴-36.57% ✅+8.96% 🔴+9.36% 🔴
Accounts47.211191.5650.5552.0151.701253.5255.0756.76+9.52% 🔴+5.20% 🔴+8.92% 🔴+9.13% 🔴
Blocks55.011018.8670.7575.2158.411307.4755.6158.67+6.18% 🔴+28.33% 🔴-21.40% ✅-21.99% ✅
Transactions62.603015.7472.0076.4269.334565.0055.6258.54+10.76% 🔴+51.37% 🔴-22.74% ✅-23.39% ✅
Test Run Duration60002.0160003.49

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@bogdan-rosianu bogdan-rosianu merged commit f8ec9c1 into development Nov 28, 2024
5 checks passed
@bogdan-rosianu bogdan-rosianu deleted the hotfix-empty-token-type-from-gateway branch November 28, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants