FIX(client): Specify version when loading/saving MainWindow state #6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebeatrici
commented
Sep 30, 2024
|
I would go a step further and compute a hash from the The hashing could be done by cmake and then be passed to the code as a macro. |
You mean hashing the file itself? |
|
Yes, exactly. Such that the hash changes every time we change the UI file. |
davidebeatrici
force-pushed
the
mainwindow-state-version
branch
from
e6a2de7
to
e213a06
Compare
davidebeatrici
changed the title
Krzmbrzl
reviewed
Oct 5, 2024
This fixes a crash caused by the state being incompatible between Qt 5 and 6. Also, by having MainWindow.ui's hash as part of the version seed we can avoid potential bugs/glitches that may arise when MainWindow's widgets are changed.
davidebeatrici
force-pushed
the
mainwindow-state-version
branch
from
e213a06
to
0a03d4e
Compare
Hartmnt
added
client
bug
Hartmnt
approved these changes
Oct 14, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash caused by the state being incompatible between Qt 5 and 6.
Please note that the default argument value for
restoreState()is 0: https://doc.qt.io/qt-6/qmainwindow.html#restoreState