Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support expectations for @media queries #33

Open
fedescarpa opened this issue Aug 21, 2018 · 4 comments
Open

support expectations for @media queries #33

fedescarpa opened this issue Aug 21, 2018 · 4 comments

Comments

@fedescarpa
Copy link
Member

We need to add expectations support for media queries in CSS

@media screen and (max-width: 720px) {
   ... content ...
}

hasMediaQuery:screen or hasMediaQuery:max-width:720px or something like that

@fedescarpa
Copy link
Member Author

¿opinions? @aguspina 📞

@aguspina
Copy link
Contributor

Sounds reasonable... de css parser already support media queries. This is an object sample:

#<CssParser::Parser:0x007fe7e2978a98 @options={:absolute_paths=>false, :import=>true, :io_exceptions=>true, :capture_offsets=>false}, @rules=[{:media_types=>[:"screen and (max-width: 720px)"], :rules=>#<CssParser::RuleSet:0x007fe7e1108da0 @selectors=["a"], @specificity=nil, @declarations={"color"=>{:value=>"red", :is_important=>false, :order=>1}}, @order=1>}], @redirect_count=nil, @loaded_uris=[], @blocks=[], @folded_declaration_cache={}, @css_source="", @css_rules=[], @css_warnings=[]>

@fedescarpa
Copy link
Member Author

fedescarpa commented Aug 21, 2018

Yes, but the runner does not support it yet

@fedescarpa
Copy link
Member Author

@flbulgarelli deberíamos tener este soporte para Mayo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants