Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Configure ruff #1193

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

ci: Configure ruff #1193

wants to merge 21 commits into from

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Dec 5, 2023

Previously ruff was not actually configured. This PR enables most of the tests there

First we look at what tests are running, and which ones need to be altered

Depends on: #1190

Only the workflows that trigger need the concurrency
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Copy link

github-actions bot commented Dec 5, 2023

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

pip install git+https://github.com/LecrisUT/jupytext.git@ci/ruff

(this requires nodejs, see more at Developing Jupytext)

@LecrisUT LecrisUT marked this pull request as draft December 5, 2023 13:51
@mwouts mwouts added this to the 1.17.0 milestone Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants