Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TLS version fallback code #1409

Closed
bgrainger opened this issue Dec 5, 2023 · 2 comments
Closed

Remove TLS version fallback code #1409

bgrainger opened this issue Dec 5, 2023 · 2 comments

Comments

@bgrainger
Copy link
Member

In #458, code was added to try TlsVersions.None first, then fall back to TLS 1.1 if that failed. This was done to accommodate yaSSL-based servers (MySQL <= 5.7.28).

This has caused multiple problems over the years:

In addition, it makes debugging TLS connection issues harder:

Since this fix was only for a major version of MySQL Server that is no longer supported (5.7), there are minor versions that don't have the problem (>= 5.7.28), TLS 1.1 should generally be avoided, and there's now a Tls Versions connection string option that could be used as a workaround, the fallback code should simply be deleted and affected users advised to use the connection string setting.

@bgrainger
Copy link
Member Author

It should also be safe to delete the fallback code added in 715c3b5 for #482.

@bgrainger
Copy link
Member Author

Fixed in 2.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant