docs

Author: Frando

iroh/src/magicsock/endpoint_map/endpoint_state.rs

@@ -1148,6 +1148,10 @@ impl ConnectionState {
 ///
 /// This is stored in the [`Connection`], and the watchables are set from within the endpoint state actor.
 ///
+/// Internally, this contains a boxed-mapped-joined watcher over the open paths in the connection and the
+/// selected path to the remote endpoint. The watcher is boxed because the mapped-joined watcher with
+/// `SmallVec<PathInfoList>` has a size of over 800 bytes, which we don't want to put upon the [`Connection`].
+///
 /// [`Connection`]: crate::endpoint::Connection
 #[derive(Clone, derive_more::Debug)]
 #[debug("PathsWatcher")]
@@ -1188,21 +1192,24 @@ impl PathsWatcher {
         selected_path: n0_watcher::Direct<Option<transports::Addr>>,
         conn_handle: WeakConnectionHandle,
     ) -> Self {
-        Self(Box::new(open_paths.or(selected_path).map(
-            move |(open_paths, selected_path)| {
-                let selected_path: Option<TransportAddr> = selected_path.map(Into::into);
-                let Some(conn) = conn_handle.upgrade() else {
-                    return PathInfoList(Default::default());
-                };
-                let list = open_paths
-                    .into_iter()
-                    .flat_map(move |(remote, path_id)| {
-                        PathInfo::new(path_id, &conn, remote, selected_path.as_ref())
-                    })
-                    .collect();
-                PathInfoList(list)
-            },
-        )))
+        Self(Box::new({
+            let inner = open_paths
+                .or(selected_path)
+                .map(move |(open_paths, selected_path)| {
+                    let selected_path: Option<TransportAddr> = selected_path.map(Into::into);
+                    let Some(conn) = conn_handle.upgrade() else {
+                        return PathInfoList(Default::default());
+                    };
+                    let list = open_paths
+                        .into_iter()
+                        .flat_map(move |(remote, path_id)| {
+                            PathInfo::new(path_id, &conn, remote, selected_path.as_ref())
+                        })
+                        .collect();
+                    PathInfoList(list)
+                });
+            inner
+        }))
     }
 }