From e617a7faaf12e52713300ebe849eaeedfa57823d Mon Sep 17 00:00:00 2001 From: Jonathan Bennetts Date: Tue, 6 Dec 2022 15:22:27 +0000 Subject: [PATCH 1/2] update notion node to remove beta wording --- .../nodes-base/nodes/Notion/DatabaseDescription.ts | 13 ------------- packages/nodes-base/nodes/Notion/Notion.node.ts | 4 ++-- .../nodes-base/nodes/Notion/NotionTrigger.node.ts | 2 +- .../nodes/Notion/v1/VersionDescription.ts | 7 ++++--- .../nodes/Notion/v2/VersionDescription.ts | 7 ++++--- 5 files changed, 11 insertions(+), 22 deletions(-) diff --git a/packages/nodes-base/nodes/Notion/DatabaseDescription.ts b/packages/nodes-base/nodes/Notion/DatabaseDescription.ts index 0aa013699bbb6..1025c9d98250a 100644 --- a/packages/nodes-base/nodes/Notion/DatabaseDescription.ts +++ b/packages/nodes-base/nodes/Notion/DatabaseDescription.ts @@ -141,19 +141,6 @@ export const databaseFields: INodeProperties[] = [ /* -------------------------------------------------------------------------- */ /* database:getAll */ /* -------------------------------------------------------------------------- */ - { - displayName: - 'In Notion, make sure you share your database with your integration . Otherwise it won\'t be accessible, or listed here.', - name: 'notionNotice', - type: 'notice', - default: '', - displayOptions: { - show: { - resource: ['database'], - operation: ['getAll'], - }, - }, - }, { displayName: 'Return All', name: 'returnAll', diff --git a/packages/nodes-base/nodes/Notion/Notion.node.ts b/packages/nodes-base/nodes/Notion/Notion.node.ts index 279d5f2e45572..5f190f631e090 100644 --- a/packages/nodes-base/nodes/Notion/Notion.node.ts +++ b/packages/nodes-base/nodes/Notion/Notion.node.ts @@ -6,12 +6,12 @@ import { NotionV2 } from './v2/NotionV2.node'; export class Notion extends VersionedNodeType { constructor() { const baseDescription: INodeTypeBaseDescription = { - displayName: 'Notion (Beta)', + displayName: 'Notion', name: 'notion', icon: 'file:notion.svg', group: ['output'], subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}', - description: 'Consume Notion API (Beta)', + description: 'Consume Notion API', defaultVersion: 2, }; diff --git a/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts b/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts index 568a2811b29fa..73a044a7995ec 100644 --- a/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts +++ b/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts @@ -10,7 +10,7 @@ import { getDatabases } from './SearchFunctions'; export class NotionTrigger implements INodeType { description: INodeTypeDescription = { // eslint-disable-next-line n8n-nodes-base/node-class-description-display-name-unsuffixed-trigger-node - displayName: 'Notion Trigger (Beta)', + displayName: 'Notion Trigger', name: 'notionTrigger', icon: 'file:notion.svg', group: ['trigger'], diff --git a/packages/nodes-base/nodes/Notion/v1/VersionDescription.ts b/packages/nodes-base/nodes/Notion/v1/VersionDescription.ts index bd3cabbe851e1..ca188380d2cb7 100644 --- a/packages/nodes-base/nodes/Notion/v1/VersionDescription.ts +++ b/packages/nodes-base/nodes/Notion/v1/VersionDescription.ts @@ -12,13 +12,13 @@ import { databasePageFields, databasePageOperations } from '../DatabasePageDescr import { INodeTypeDescription } from 'n8n-workflow'; export const versionDescription: INodeTypeDescription = { - displayName: 'Notion (Beta)', + displayName: 'Notion', name: 'notion', icon: 'file:notion.svg', group: ['output'], version: 1, subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}', - description: 'Consume Notion API (Beta)', + description: 'Consume Notion API', defaults: { name: 'Notion', }, @@ -67,7 +67,8 @@ export const versionDescription: INodeTypeDescription = { // description: 'The resource to operate on.', // }, { - displayName: "To access content, make sure it's shared with your integration in Notion", + displayName: + 'In Notion, make sure to add your connection to the pages you want to access.', name: 'notionNotice', type: 'notice', default: '', diff --git a/packages/nodes-base/nodes/Notion/v2/VersionDescription.ts b/packages/nodes-base/nodes/Notion/v2/VersionDescription.ts index a496d1a05157e..f2462c7c22b29 100644 --- a/packages/nodes-base/nodes/Notion/v2/VersionDescription.ts +++ b/packages/nodes-base/nodes/Notion/v2/VersionDescription.ts @@ -12,13 +12,13 @@ import { databasePageFields, databasePageOperations } from '../DatabasePageDescr import { INodeTypeDescription } from 'n8n-workflow'; export const versionDescription: INodeTypeDescription = { - displayName: 'Notion (Beta)', + displayName: 'Notion', name: 'notion', icon: 'file:notion.svg', group: ['output'], version: 2, subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}', - description: 'Consume Notion API (Beta)', + description: 'Consume Notion API', defaults: { name: 'Notion', }, @@ -67,7 +67,8 @@ export const versionDescription: INodeTypeDescription = { // description: 'The resource to operate on.', // }, { - displayName: "To access content, make sure it's shared with your integration in Notion", + displayName: + 'In Notion, make sure to add your connection to the pages you want to access.', name: 'notionNotice', type: 'notice', default: '', From 5d27cd5e8fa17e3f6b254c7c6a3224990336b363 Mon Sep 17 00:00:00 2001 From: Jonathan Bennetts Date: Tue, 6 Dec 2022 15:43:15 +0000 Subject: [PATCH 2/2] updated wording on Notion trigger --- packages/nodes-base/nodes/Notion/NotionTrigger.node.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts b/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts index 73a044a7995ec..01b5d0a4e4851 100644 --- a/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts +++ b/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts @@ -49,7 +49,7 @@ export class NotionTrigger implements INodeType { }, { displayName: - 'In Notion, make sure you share your database with your integration . Otherwise it won\'t be accessible, or listed here.', + 'In Notion, make sure to add your connection to the pages you want to access.', name: 'notionNotice', type: 'notice', default: '',