Add primary key to create table query in postgres dialect #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimxogus
changed the title
nafg
force-pushed
the
master
branch
7 times, most recently
from
24176d9
to
4373aa5
Compare
nafg
force-pushed
the
primary-key-in-create-table
branch
from
7d2f808
to
d0f31ad
Compare
nafg
requested changes
Oct 24, 2022
| xs.foldLeft((List.empty[B], List.empty[A])) { | ||
| case ((bs, as), a) => | ||
| toB.andThen(b => (b :: bs, as)).applyOrElse(a, (_: A) => (bs, a :: as)) | ||
| private def partition(xs: List[TableMigration.Action]): (List[AddColumn], List[AddPrimaryKey], List[TableMigration.Action]) = |
There was a problem hiding this comment.
Why did you have to change partition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use slick-migration-api with
cockroachdb.As cockroachdb doesn't support updating pk, primary keys must be in create table query.
Therefore I added primary key declaration in create table query postgres dialect.