diff --git a/.changeset/tricky-zebras-itch.md b/.changeset/tricky-zebras-itch.md new file mode 100644 index 0000000..896c2a1 --- /dev/null +++ b/.changeset/tricky-zebras-itch.md @@ -0,0 +1,5 @@ +--- +"@nailyjs/cli": patch +--- + +feat(cli): update killer diff --git a/packages/cli/package.json b/packages/cli/package.json index b292720..9b2db92 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -32,7 +32,6 @@ "dependencies": { "@nailyjs/config": "workspace:*", "@nailyjs/ioc": "workspace:*", - "@nailyjs/winston": "workspace:*", "chokidar": "^4.0.1", "commander": "^12.1.0", "defu": "^6.1.4", diff --git a/packages/cli/src/development-runner.service.ts b/packages/cli/src/development-runner.service.ts index bef715b..bb41e44 100644 --- a/packages/cli/src/development-runner.service.ts +++ b/packages/cli/src/development-runner.service.ts @@ -5,17 +5,17 @@ import { Service } from '@nailyjs/ioc' @Service() export class DevelopmentRunnerService { - createProcess(filePath: string): () => void { + createProcess(filePath: string): () => boolean { const resolvedFilePath = path.resolve(filePath) const forked = child_process.spawn('node', [resolvedFilePath]) - const dout = forked.stdout?.pipe(stdout) - const derr = forked.stderr?.pipe(stderr) + const forkStdout = forked.stdout?.pipe(stdout) + const forkStderr = forked.stderr?.pipe(stderr) - function killer(signal: NodeJS.Signals | number = 0): void { - dout?.unpipe(stdout) - derr?.unpipe(stderr) - forked.kill(signal) + function killer(signal: NodeJS.Signals | number = 0): boolean { + forkStdout?.unpipe(stdout) + forkStderr?.unpipe(stderr) + return forked.kill(signal) } return killer diff --git a/packages/cli/src/development.service.ts b/packages/cli/src/development.service.ts index eccf8c4..3ae287e 100644 --- a/packages/cli/src/development.service.ts +++ b/packages/cli/src/development.service.ts @@ -26,7 +26,7 @@ export class DevelopmentStarter implements Setupable { this.logoWriter.write() } - private killer: () => void = () => true + private killer: () => boolean = () => true private async run(): Promise { await this.tsupService.setup() this.refreshScreen() diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index ceddde8..a619960 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -185,9 +185,6 @@ importers: '@nailyjs/ioc': specifier: workspace:* version: link:../ioc - '@nailyjs/winston': - specifier: workspace:* - version: link:../winston chokidar: specifier: ^4.0.1 version: 4.0.1