-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/ko: Add some missing option on uftrace-live.md in Korean #1967
base: master
Are you sure you want to change the base?
Conversation
Hi, EmpChan. As described in #1957, it looks like you've created a commit after forking, after deleting the branch and forked repository while the previous PR still exists, which is not what we want. Of course, I could confirm that the two issues identified in the previous PR have been resolved, but it appears that the PR created one unnecessary commit to fix the Therefore, the Please navigate to your local repository and run the command below to get it into a state where you can squash it.
You should see something like the screen below, change the second
After:
The next screen, shown below, is for creating a commit message to be displayed after combining the two commits, and since we only need the contents of the first commit, we erase the contents of the second commit as shown below, save and exit. (The
After:
Finally, if you run into any problems while making changes or don't know what to do, leave a comment and we'll try to help :) |
Thanks for comments. |
I checked the branch in
Could you please share here the results of the top two commits from your |
The results of the I should have removed the unnecessary part of the commit that starts with
The above command will open a window to edit the commit message, remove the unnecessary commits from the line starting with Then run |
I pushed with out delete spaces message. |
These two missing options are translated and added to 'uftrace-live.md' LIVE options, -p PID, --pid=PID RECORD config options, -g, --agent Signed-off-by: JaeChanHwang <hss598876@gmail.com>
Hello @honggyukim. I'm checked and change my commit. Thanks for opportunity to contribute this project!! |
Thanks but I still see the conflict so please rebase your change based on the current master. |
Signed-off-by: JaeChanHwang <hss598876@gmail.com>
I try next steps but i dont know how rebase it.. I cant find my commit "Merge branch 'master' into master" even in
how can i resolve it ? |
You need to have real uftrace repo in your remote branch. I assume you have your change at HEAD (check if And this can be done just once.
After that you can run this command to rebase.
|
These four missing options are translated and added to 'uftrace-live.md'