-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bindgen dependency #4
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, and thanks for the contribution!
It seems like 5336811 includes the (unmerged) changes made in #3.
As the only other change in that commit is the addition of the Cargo.lock
file (see my other comment), I'll probably merge #3 and then exclude that specific commit when merging this PR in order to preserve the proper commit history.
Aside from that and the other comment this PR looks good to me.
Just as a general disclaimer: Because we've not been actively working on a project targeting OpenWRT for quite some time1, this library has not been as well maintained as it probably should have been.
I intend to do some clean up and some smaller improvements before publishing a new release to crates.io (most notably #5 to allow for some basic automated testing).
However, because I am currently occupied with other stuff, this might take some time, and you might have to resort to using the git version of this crate until then.
Footnotes
-
Our previous project that was using this library has not been maintained for a few years now. ↩
Hi. Thank you for the feedback. Sorry for having the uci list changes included here. It wasn't intended but I had forgotten about this pr and just moved to using my fork as the dependency, since I needed the changes to be in. |
Hi @Bucket-Bucket-Bucket, thank you for the update! Could you maybe remove 5336811 from this PR (e.g., using an interactive rebase)? I think then we could go forward with this one independently of the changes incorporated from #3. |
d213c9b
to
bafebd0
Compare
Ended up just moving the uci list commits to a separate branch and dropping them from this, since they shouldn't have been here in the first place. |
Just a bindgen version update and a fix to one call that's been deprecated.
Recently did some OpenWrt building on Ubuntu 24.04 which failed due to a newer clang version being used. This update fixes it without any further issue.