Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for optionally typed inputs and outputs #32

Merged
merged 4 commits into from
Jun 13, 2019
Merged

Add support for optionally typed inputs and outputs #32

merged 4 commits into from
Jun 13, 2019

Commits on Jun 13, 2019

  1. Add support to allow for optionally typed inputs and outputs 

    This allows for optionally specifying the full types of the inputs and
outputs of a `Node` during implementation by allowing to specify a full,
freestanding function, rather than only an expression.

The function's arguments and return type will be parsed to produce the
number of inputs and outputs for the node, where the number of arguments
is the number of inputs, and the number of tuple arguments in the output
is the number of outputs (1 if no tuple output type).

Some of this may have to be re-written when addressing a few follow-up
issues including nannou-org#29, nannou-org#19, nannou-org#21 and nannou-org#22, but I think it's helpful to
break up progress into achievable steps!

Closes nannou-org#27 and makes nannou-org#20 much more feasible.
    @mitchmindtree
    mitchmindtree committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    acb446b View commit details
    Browse the repository at this point in the history

  2. Address dyn related warnings on latest nightly

    @mitchmindtree
    mitchmindtree committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    a66199b View commit details
    Browse the repository at this point in the history

  3. Add a second graph test for node function evaluation

    @mitchmindtree
    mitchmindtree committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    b47c8b2 View commit details
    Browse the repository at this point in the history

  4. Address dyn warnings in graph tests

    @mitchmindtree
    mitchmindtree committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    a7e1855 View commit details
    Browse the repository at this point in the history