Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues with argument parsing in poetry 2.0 plugin #277

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

nat-n
Copy link
Owner

@nat-n nat-n commented Feb 24, 2025

Fixes #270

  • Create a PoeConfig once on plugin initialization, and reuse it in the command. This allows the plugin to find the config before the working directory is updated as a result of including the --directory option.
  • Update the cleo monkeypatch to account for --directory and --project options taking an argument and being rewritten to precede the command.

Also:

  • disable poetry plugins when calling the poetry CLI inside PoetryExecutor
  • Duplicate poetry plugin tests to run with two poetry versions

Fixes #270

- Create a PoeConfig once on plugin initialization, and reuse it in the command.
  This allows the plugin to find the config before the working directory is
  updated as a result of including the `--directory` option.
- Update the cleo monkeypatch to account for --directory and --project options
  taking an argument and being rewritten to precede the command.

Also:
- disable poetry plugins when calling the poetry CLI inside PoetryExecutor
- Duplicate poetry plugin tests to run with two poetry versions
@nat-n nat-n changed the base branch from main to development February 24, 2025 21:04
@nat-n nat-n merged commit 31daded into development Feb 24, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PATH argument doesn't work after 0.32.1
1 participant