Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support for distinct on arrays #22

Open
andrewdbate opened this issue Mar 7, 2015 · 2 comments
Open

Feature request: support for distinct on arrays #22

andrewdbate opened this issue Mar 7, 2015 · 2 comments

Comments

@andrewdbate
Copy link

I am now heavily using Scalaxy/Streams in my current project, and it is crucial to our performance. :-)

However, I frequently have an Array[Array[X]] and call flatten and then distinct. Scalaxy seems to support flatten if the foolish optimization strategy is used (which I didn't know earlier). It would be great if distinct were supported as well.

Perhaps you could update the readme.md to list that flatten is supported too?

Thanks again for all of the brilliant work!

@andrewdbate andrewdbate changed the title Feature request: support for flatten on arrays Feature request: support for flatten and distinct on arrays Mar 7, 2015
@andrewdbate andrewdbate changed the title Feature request: support for flatten and distinct on arrays Feature request: support for distinct on arrays Mar 7, 2015
@andrewdbate
Copy link
Author

I've edited this issue too many times now... sorry about that. I seem to have confused myself about Scalaxy's support for flatten. I've now decompiled the bytecode, and it seems that, although Scalaxy gives some output to suggest something is going on with flatten, it isn't optimized out. Would support for flatten be possible?

@ochafik
Copy link
Member

ochafik commented Mar 18, 2015

It's definitely possible, with some devil in the details... Testing a proto right now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants