Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): switch to nativescript-socketio and fix toaster #9

Merged
merged 1 commit into from
Mar 30, 2019
Merged

fix(deps): switch to nativescript-socketio and fix toaster #9

merged 1 commit into from
Mar 30, 2019

Conversation

anthonny
Copy link
Contributor

This pull request fixes #6 #8

I use this dependencies:

"nativescript-toasty": "*",
"nativescript-socketio": "*",

instead of:

"nativescript-toast": "*",	    
"nativescript-socket.io": "*",

@anthonny
Copy link
Contributor Author

anthonny commented Mar 29, 2019 •
edited
Loading

To be honnest, a part of the job was made here:

https://github.com/nativescript-vue/nativescript-vue-devtools/pull/7/files

But does not work with nativescript-toast
I can close this PR and make changes on the @lafriks branch if you want

@rigor789 rigor789 merged commit 9eec312 into nativescript-vue:master Mar 30, 2019
@rigor789 rigor789 mentioned this pull request Mar 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency nativescript-socket.io does not seem to work with nativescript-vue 2.0
2 participants
@anthonny @rigor789