[JS] direct get apis include old Nats- headers creating duplicates

[aricart]

What version were you using?

2.10.1

What environment was the server running in?

any

Is this defect reproducible?

To reproduce the error:

Save this program to direct_issue.ts

import { parse } from "https://deno.land/std@0.202.0/flags/mod.ts";
import { connect, StorageType, nuid } from "https://raw.githubusercontent.com/nats-io/nats.deno/main/src/mod.ts";
import { JetStreamManagerImpl } from 'https://raw.githubusercontent.com/nats-io/nats.deno/main/jetstream/jsm.ts'
import { MsgHdrsImpl } from 'https://raw.githubusercontent.com/nats-io/nats.deno/main/nats-base-client/headers.ts'

const opts = parse(Deno.args);

if (opts.h || opts.help) {
  console.log("deno run -A direct_issue.ts --server hostport --help");
}
const servers = opts.server || opts.s || "localhost:4222";

const nc = await connect({ servers });

const jsm = await nc.jetstreamManager() as JetStreamManagerImpl;

const name = nuid.next();


await jsm.streams.add({
  name: name,
  subjects: ["A.>"],
  storage: StorageType.Memory,
  republish: {
    src: ">",
    dest: `$KV.${name}.>`,
  },
});

const js = nc.jetstream();
const B = await js.views.kv(name);

nc.publish("A.orange", "hey");
await js.publish("A.tomato", "hello");
await B.put("A.potato", "yo");

console.log("direct gets");
for (let i = 1; i <= 3; i++) {
  const m = await jsm.direct.getMessage(`KV_${name}`, { seq: i });
  console.log((m.header as MsgHdrsImpl).toString());
  console.log("-------------");
}
console.log("stream gets");
for (let i = 1; i <= 3; i++) {
  const m = await jsm.streams.getMessage(`KV_${name}`, { seq: i });
  console.log((m.header as MsgHdrsImpl).toString());
  console.log("-------------");
}

await jsm.streams.delete(name);
await B.destroy()
await nc.close()

Start a nats server with JetStream

> deno run -A direct_issue.ts

direct gets
NATS/1.0
Nats-Stream: Z0EZD0S7VBF6EL9SL4SN5I
Nats-Stream: KV_Z0EZD0S7VBF6EL9SL4SN5I
Nats-Subject: A.orange
Nats-Subject: $KV.Z0EZD0S7VBF6EL9SL4SN5I.A.orange
Nats-Sequence: 1
Nats-Sequence: 1
Nats-Last-Sequence: 0
Nats-Time-Stamp: 2023-09-22T11:35:36.861641Z


-------------
NATS/1.0
Nats-Stream: Z0EZD0S7VBF6EL9SL4SN5I
Nats-Stream: KV_Z0EZD0S7VBF6EL9SL4SN5I
Nats-Subject: A.tomato
Nats-Subject: $KV.Z0EZD0S7VBF6EL9SL4SN5I.A.tomato
Nats-Sequence: 2
Nats-Sequence: 2
Nats-Last-Sequence: 0
Nats-Time-Stamp: 2023-09-22T11:35:36.86172Z


-------------
NATS/1.0
Nats-Stream: KV_Z0EZD0S7VBF6EL9SL4SN5I
Nats-Subject: $KV.Z0EZD0S7VBF6EL9SL4SN5I.A.potato
Nats-Sequence: 3
Nats-Time-Stamp: 2023-09-22T11:35:36.862229Z


-------------
stream gets
NATS/1.0
Nats-Stream: Z0EZD0S7VBF6EL9SL4SN5I
Nats-Subject: A.orange
Nats-Sequence: 1
Nats-Last-Sequence: 0


-------------
NATS/1.0
Nats-Stream: Z0EZD0S7VBF6EL9SL4SN5I
Nats-Subject: A.tomato
Nats-Sequence: 2
Nats-Last-Sequence: 0
-------------

Given the capability you are leveraging, describe your expectation?

The headers from the added by the stream republish onboarding into KV shouldn't be reported. The side effect of that is Get operations trying to figure out the name of the key will fail, as there are multiple Nats-Subject entries (as well as sequence etc.).

Nats-Subject: A.tomato
Nats-Subject: $KV.1RHFTJKE86C02I6P51LXR3.A.tomato

For KV implementations, there's a check on the subject header - depending on what the map implementation does, it may get one or the other header (go gets the second). The algorithm will remove the prefix, which then yields a key that is different from what the client is looking for resulting in a not found error on the lookup.

Given the expectation, what is the defect you are observing?

Nats- headers shouldn't have duplicates.