[TEST only] A test for memory leak when creating/deleting consumers #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derekcollison @neilalexander https://app.travis-ci.com/github/nats-io/nats-server/jobs/623464530 is causing a race in raft, do you mind taking a look? This line here is not being executed under a lock. https://github.com/nats-io/nats-server/pull/5600/files#diff-0a3d4e9b87bb3880bdb735fa489ef618b571de3370dae31d8f509b26e2fb852eR1737 when called from |
Signed-off-by: Derek Collison <derek@nats.io>
levb
force-pushed
the
GH-5471-leak-JS-only
branch
from
cacf693 to
eb79e36
Compare
levb
force-pushed
the
GH-5471-leak-JS-only
branch
from
eb79e36 to
a1e2de7
Compare
|
Apologies, but either I messed something up when merging/rebasing or GitHub is having issues, I will close this PR and submit a new one since there's little history here anyway. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies the fix in #5600
When ran locally, it was using ~180MB extra for the test before, and under 40Mb after.