Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export LameDuckShutdown so that it is accessible when embedding NATS #5660

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Export LameDuckShutdown so that it is accessible when embedding NATS #5660

merged 1 commit into from
Jul 16, 2024

Conversation

neilalexander
Copy link
Member

Otherwise this function isn't available when embedding the NATS Server, where using SIGUSR2 likely isn't appropriate.

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander neilalexander requested a review from a team as a code owner July 16, 2024 13:35
derekcollison
derekcollison requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To minimize changes just make public one call private one.

wallyqs
wallyqs reviewed Jul 16, 2024
View reviewed changes
server/server.go Outdated Show resolved Hide resolved
@neilalexander
Rename lameDuckMode to LameDuckShutdown so that it is accessible …
11c5ba2 
…when embedding NATS

Otherwise this function isn't available when embedding the NATS Server,
where using `SIGUSR2` likely isn't appropriate.

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander changed the title Rename lameDuckMode to LameDuckShutdown so that it is accessible when embedding NATS Export LameDuckShutdown so that it is accessible when embedding NATS Jul 16, 2024
@derekcollison derekcollison self-requested a review July 16, 2024 21:07
derekcollison
derekcollison approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit fd284c8 into main Jul 16, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/ldmapi branch July 16, 2024 21:08
@wallyqs wallyqs mentioned this pull request Jul 16, 2024
Merged
wallyqs added a commit that referenced this pull request Jul 16, 2024
@wallyqs
Cherry-picks for 2.10.18-RC.4 (#5664)
ff36cf0 
Includes:

- #5662
- #5663
- #5660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs left review comments

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilalexander @wallyqs @derekcollison