Cherry picks for v2.10.19 RC4 #5769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we might add the entry into the cache and then immediately prune it afterwards, depending on luck/map iteration order. Signed-off-by: Neil Twigg <neil@nats.io>
The server would send the reply back to the client before removing message from the stream, which could cause some issues if the client expected the message to be removed after the AckSync() call returns. For instance, a WorkQueue that would have a max message of 1 per subject and discard new message would fail a client that got a message, ack it, and re-puplish this message. Depending on timing, the client may get and error `maximum messages per subject exceeded`. Used @pcsegal description of the problem and example code to write a test that demonstrated the issue before the fix. Resolves #5702 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Neil Twigg <neil@nats.io>
…erly synched with the leader before proceeding. Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
orderedconstraint now that we can usecmp.Ordered#5763