[FIXED] Fix consumer start sequence when sequence not yet in stream #5785
+66
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Twigg <neil@nats.io>
wallyqs
changed the title
derekcollison
added a commit
that referenced
this pull request
Oct 17, 2024
This PR backs out #5785, which was released in v2.10.19, as it has a negative impact on sourcing and mirroring. See discussion at #6005. Two new unit tests, `TestJetStreamSourcingClipStartSeq` and `TestJetStreamMirroringClipStartSeq`, are added to show this behaviour in action. We will probably want to revisit this for 2.11 so that we can come up with something that works for both use-cases. Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consumer
sseqwas being clipped back to the range between the streamFirstSeqandLastSeqeven when the consumer start sequence was provided, so it wasn't possible to provide a start sequence that didn't exist in the stream yet. This PR changes that to now obey the start sequence even in that case.Note that this problem will still exist with the consumer start timestamp, as that's predicated on being able to match the timestamp to a sequence number in the stream, which it won't be able to do if the stream doesn't contain any sequences for that time.
Signed-off-by: Neil Twigg neil@nats.io