[FIXED] Fix 0 expected last seq per subject for clustered stream #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getExpectedLastSeqPerSubject` check in `processJetStreamMsg` would take into account that we could get a create/seq=0 for last seq per subject. However, the `processClusteredInboundMsg` would NOT take this into account. This would result in sending the message to all replicas. If any replica would store instead of reject the message, it would desync. Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
added a commit
that referenced
this pull request
Aug 16, 2024
wallyqs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getExpectedLastSeqPerSubjectcheck inprocessJetStreamMsgwould take into account that we could get a create/seq=0 for last seq per subject.However, the
processClusteredInboundMsgwould NOT take this into account. This would result in sending the message to all replicas. If any replica would store instead of reject the message, it would desync.The reproducible example from below issue doesn't reproduce anymore after this fix.
Resolves #5644
Signed-off-by: Maurice van Veen github@mauricevanveen.com